Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add note to update the pdk-templates lint whenever it is changed here #478

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Oct 21, 2024

In order to ensure that our lint testing remains in step we must keep these two files in sync with eachother:

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.95%. Comparing base (d580571) to head (7700f4b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   43.95%   43.95%           
=======================================
  Files          10       10           
  Lines         662      662           
=======================================
  Hits          291      291           
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @david22swan !

@gavindidrichsen gavindidrichsen merged commit c06c7bb into main Oct 21, 2024
10 checks passed
@gavindidrichsen gavindidrichsen deleted the lint_note branch October 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants