Skip to content

Commit

Permalink
feat: update browserslist to > 1%
Browse files Browse the repository at this point in the history
  • Loading branch information
@redonkulus
redonkulus committed Oct 26, 2022
1 parent e5b0a01 commit 91ad930
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 25 deletions.
36 changes: 16 additions & 20 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,7 @@
"jamesalley <[email protected]>"
],
"license": "BSD-3-Clause",
"browserslist": [
"last 2 versions",
"iOS >= 12",
"Android >= 6"
],
"browserslist": "> 1%",

This comment has been minimized.

Sign in to view

Copy link
@septatrix

septatrix Oct 26, 2022

Contributor

Although this is rarely a problem, this might exclude newly released browsers. See "Select browser versions with certain usage > BEWARE" on https://browsersl.ist/.

The defaults query might be more appropriate and is equivalent to > 0.5%, last 2 versions, Firefox ESR, not dead

This comment has been minimized.

Sign in to view

Copy link
@redonkulus

redonkulus Oct 26, 2022

Author Contributor

Good catch, if it becomes a problem I can adjust it but I think it should be ok since we are using standard features that have been around for a long time within the code base.
"husky": {
"hooks": {
"pre-commit": "npm test"
Expand Down

0 comments on commit 91ad930

Please sign in to comment.