taint process output #270
Merged
taint process output #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the Purebred.Types.IFC module for information flow control (IFC) types and functions. We begin with a trivial taint mechanism. A single aspect of the implementation - tryRunProcess - is updated to use it, for demonstration and review purposes. Part of: #269
Taint sendmail stderr. Also re-export some typed-process ProcessConfig-related types and functions from Purebred.System.Process. This is a move to avoid importing System.Process.Typed anywhere in purebred, except this one module, ensuring that all the "run process" functions that are available taint the process output. Part of: #269
Create tainting version of readProcess and update Storage.Notmuch.getDatabasePath to use it. Part of: #269
Re-export 'shell' from Purebred.System.Process so that we can avoid directly importing System.Process.Typed anywhere (except the aforementioned module). We want to avoid using typed-process directly; instead we want to ensure we use our own variants that taint the process output. Part of: #269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #269