Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: update dependencies for brick 2.1 #513

Closed
wants to merge 3 commits into from
Closed

Conversation

lucc
Copy link
Contributor

@lucc lucc commented Nov 20, 2023

Fix #512

This still fails because of missing dependencies. Feel free to add more commits, I don't know how much time I have in the following days.

From the brick changelog:

  • Added dependency on vty-crossplatform.
  • Migrated from unix dependency to unix-compat.

So we should probably also package the missing vty-crossplatform and vty-unix from the build og:

configuring
configureFlags: --verbose --prefix=/nix/store/3xj0f2c4jy2brzi0lcky7y1804kla84s-brick-2.1.1 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/dp849yq7s7pd8lfbj2386kbb8r16cgv7-brick-2.1.1-doc/share/doc/brick-2.1.1 --with-gcc=gcc --package-db=/build/tmp.jWJYssY18F/package.conf.d --ghc-options=-j4 +RTS -A64M -RTS --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --ghc-options=-haddock --extra-lib-dirs=/nix/store/vhgj0kyl1ijq408w9j0n4iq1ycrhhhfl-ncurses-6.3-p20220507/lib --extra-lib-dirs=/nix/store/94p2qrkvb9h0m7h5p0by88z0gzzaxl36-libffi-3.4.2/lib --extra-lib-dirs=/nix/store/14aarvmjm8xcq3ma0mxdfh59xmbpw284-gmp-with-cxx-6.2.1/lib
Using Parsec parser
Configuring brick-2.1.1...

Setup: Encountered missing or private dependencies:
vty-crossplatform, vty-unix

@romanofski
Copy link
Member

So it seems the only way I can update your pull request is by creating a new pull request :-[

@romanofski
Copy link
Member

So I created: #514 feel free to cherry pick from there or we merged that instead. Up to you. Basically the gist is that it needed overwrites added for vty-unix and vty-crossplatform, as well as a cabal2nix update for brick.nix and vty adding the dependencies.

@frasertweedale
Copy link
Member

#514 was merged. Closing this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e6d2474 beaks nix build
3 participants