node.js support, via npm package 'xmlhttprequest' #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also if you merge #31 first, then I can rebase this and set Travis up to run the tests on node.js. :) |
|
Please do! |
|
Actually I'll sort out #30 first. |
|
I couldn't get it to run in Gulp, so I tried it inside the travis script, but that doesn't appear to work either (if you look at the travis log, it looks like it's only running the first test). Issuing the same commands as those that are in the travis script does work locally though. I've no idea what's wrong or how to fix it :( |
|
Can you rebase this please? I've broken one of your PRs once again somehow 😉 |
|
Thanks! |
garyb
added a commit
that referenced
this pull request
Aug 5, 2015
node.js support, via npm package 'xmlhttprequest'
|
It's great that the tests can be run by Travis now too, thanks very much. 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29. This passes all the tests in my other PR, but currently you have to set up an http server on port 80 to proxy to the test server to get them to work.