Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push snap qa fixes #1261

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Push snap qa fixes #1261

merged 9 commits into from
Oct 3, 2023

Conversation

abhishek-01k
Copy link
Collaborator

  • Dark Mode for /snap route is done
  • Responsiveness added to the /snap route

@github-actions
Copy link

File: src/modules/receiveNotifs/MetamaskPushSnapModal.tsx

  1. In line 14, there's a typo in the import statement. It should be "InstallMetamaskSnapModal" instead of "InstallMetamaskSnapModal".

  2. In line 27, the condition inside the if statement is not properly enclosed in parentheses. It should be written as "(SnapState !== 1)".

  3. In line 34, the condition inside the if statement is not properly enclosed in parentheses. It should be written as "(SnapState === 1)".

  4. In line 43, the condition inside the if statement is not properly enclosed in parentheses. It should be written as "(SnapState == 1)".

  5. In line 44, the condition inside the if statement is not properly enclosed in parentheses. It should be written as "(SnapState == 2)".

  6. In line 45, the condition inside the if statement is not properly enclosed in parentheses. It should be written as "(SnapState == 3)".

  7. In line 48, there's a missing closing parenthesis after the closing curly brace. It should be written as "})" instead of "}".

  8. In line 39, there's an unused import statement for the GLOBALS constant. It can be removed.

File: src/modules/snap/AboutSnapModal.tsx

  1. In line 13, there's a missing opening curly brace before the title property. It should be written as "{title: 'Step 1', ...}" instead of "title: 'Step 1', ...}".

  2. In line 14, there's a missing closing parenthesis after the info property. It should be written as "'Connect your wallet using MetaMask to receive notifications')" instead of "'Connect your wallet using MetaMask to receive notifications'".

  3. In line 15, there's a missing opening curly brace before the title property. It should be written as "{title: 'Step 2', ...}" instead of "title: 'Step 2', ...}".

  4. In line 16, there's a missing closing parenthesis after the info property. It should be written as "'Opt-in channels on app.push.org/channels and you’re all set.')" instead of "'Opt-in channels on app.push.org/channels and you’re all set'".

  5. In line 17, there's a missing opening curly brace before the title property. It should be written as "{title: 'Step 3', ...}" instead of "title: 'Step 3', ...}".

  6. In line 18, there's a missing closing parenthesis after the info property. It should be written as "'You can visit app.push.org/snap, click on Settings and Add Wallets, Show All to remove wallets, and Snooze Notification Pop-ups.')" instead of "'You can visit app.push.org/snap, click on Settings and Add Wallets, Show All to remove wallets, and Snooze Notification Pop-ups'".

  7. In line 37, there's an unused import statement for the styled constant. It can be removed.

File: src/modules/snap/SnapModule.tsx

  1. In line 10, there's a missing opening parenthesis after the opening curly brace. It should be written as "{ showMetamaskPushSnap, setSnapState }" instead of "{ showMetamaskPushSnap, setSnapState })".

  2. In line 27, there's an unused import statement for the PushSnapModal component. It can be removed.

  3. In line 40, there's an unused import statement for the useModalBlur hook. It can be removed.

  4. In line 42-43, there's a missing opening parenthesis after the opening curly brace and a missing closing parenthesis before the closing curly brace. It should be written as "{ InnerComponent: AboutSnapModalComponent }" instead of "InnerComponent: AboutSnapModalComponent }".

  5. In line 101, there's a missing closing parenthesis in the handleClick function. It should be written as "onClick={() => onClose()}" instead of "onClick={() => onClose}".

  6. In line 112-113, there's a missing closing parenthesis after the closing curly brace and a missing opening curly brace before the title property. It should be written as "{title: 'Step 4 (optional)', ...}" instead of "title: 'Step 4 (optional)', ...}".

All looks good.

Arch0125
Arch0125 previously approved these changes Sep 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

All looks good.

@0xNilesh 0xNilesh merged commit 0213508 into main Oct 3, 2023
1 check passed
0xNilesh added a commit that referenced this pull request Oct 10, 2023
* Push snap qa fixes (#1261)

* Snap UI fixes from QA-1

* fix: connected snap address detection

* fix: snooze toggle

* fix: address detection bug

* fix: spacing in signature

* update: route bug

* Snap Dark mode fix and responsiveness added

* Added dark mode to Snap QA

---------

Co-authored-by: Arch0125 <[email protected]>

* Added support for arbitrum

* Resolved issues

* Updated sdk package versions

* chore: integrate channel settings and send notif

* chore: design update for send notif page and minor fixes

* chore: move tag to reusables

* fix: rename folder to avoid .gitignore file

---------

Co-authored-by: Abhishek <[email protected]>
Co-authored-by: Arch0125 <[email protected]>
Co-authored-by: Nilesh Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

3 participants