Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptIn, Opt Out, send notification and Create Channel guest mode #1334

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 6, 2023

File: src/components/SendNotifications.tsx

  • Typo: "componnets" should be "components" (Line 14)
  • Typo: "reusables" should be "reusable" (Line 19)
  • Typo: "recipeints" should be "recipients" (Line 56)
  • Typo: "nfSubEnabled" should be "nfCTAEnabled" (Line 50)
  • Typo: "notifcation" should be "notification" (Line 95)
  • Typo: "if we are sending" should be "if we are sending for" (Line 105)
  • Typo: "notifcation subject" should be "notification subject" (Line 116)
  • Typo: "Incorrect Payload" should be "Incorrect payload" (Line 127)
  • Typo: "userPushSDKInstance" is in camel case format and should be in "userPushSdkInstance" format (Line 29)
  • Missing closing parenthesis ")" after "state.canSend" (Line 38)
  • Move the closing brace "}" from line 55 and place it after line 43 for better code readability
  • Missing closing parenthesis ")" after "setNFRecipient" in the removeRecipient function (Line 69)
  • Move the closing brace "}" from line 81 and place it after line 75 for better code readability
  • Move the closing brace "}" from line 97 and place it after line 90 for better code readability
  • Move the closing brace "}" from line 135 and place it after line 129 for better code readability
  • Move the closing brace "}" from line 171 and place it after line 165 for better code readability
  • Move the closing brace "}" from line 195 and place it after line 189 for better code readability
  • Missing closing parenthesis ")" after "bodyValidated" function call in the handleSendMessage function (Line 212)
  • Move the closing brace "}" from line 254 and place it after line 211 for better code readability

File: src/components/channel/NotificationSettings.tsx

  • Typo: "channe" should be "channel" (Line 59)
  • Typo: "channelSettings" should be "ChannelSetting" (Line 102)
  • Typo: "isAddSettingModalOpen" should be "isModalOpen" (Line 135)
  • Typo: "pushProtocoInstance" should be "userPushSDKInstance" (Line 22)
  • Missing closing parenthesis ")" after "state.user" (Line 20)
  • Missing closing parenthesis ")" after "state.admin" (Line 21)
  • Missing closing parenthesis ")" after "state.channels" (Line 22)
  • Missing closing parenthesis ")" after "state.contracts" (Line 23)
  • Move the closing brace "}" from line 69 and place it after line 53 for better code readability
  • Move the closing brace "}" from line 84 and place it after line 78 for better code readability
  • Move the closing brace "}" from line 100 and place it after line 94 for better code readability
  • Move the closing brace "}" from line 126 and place it after line 120 for better code readability
  • Move the closing brace "}" from line 150 and place it after line 144 for better code readability
  • Move the closing brace "}" from line 173 and place it after line 167 for better code readability
  • Move the closing brace "}" from line 187 and place it after line 181 for better code readability
  • Move the closing brace "}" from line 203 and place it after line 197 for better code readability
  • Move the closing brace "}" from line 222 and place it after line 214 for better code readability
  • Missing closing parenthesis ")" after "handleConnectWallet" function call (Line 69)
  • Missing closing parenthesis ")" after "setSettings" function call (Line 115)
  • Missing closing parenthesis ")" after "setSettingToEdit" function call (Line 120)
  • Missing closing parenthesis ")" after "setSettings" function call (Line 129)

File: src/hooks/useAccount.tsx

  • Typo: "connnectedChain" should be "connectedChain" (Line 9)
  • Typo: "chainnId" should be "chainId" (Line 37)
  • Typo: "ethers.utils.hexValue"

Copy link

github-actions bot commented Dec 7, 2023

All looks good.

@abhishek-01k abhishek-01k merged commit a729c1a into Read-Only-Feature-for-Dapp Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants