Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard modal style improvements #1339

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

kalashshah
Copy link
Contributor

No description provided.

Copy link

In the file src/AppLogin.tsx:

  • Line 7: ReactGA.pageview('/login'); - It seems that ReactGA is not imported. Please import it from the appropriate package.
  • Line 14: const { isActive, connect, wallet } = useAccount(); - useAccount is not imported. Please import it from the appropriate package.
  • Line 33: const [loading, setLoading] = useState(true); - It seems that useState is not imported. Please import it from the appropriate package.
  • Line 49: let observer: ResizeObserver | undefined; - useState is missing a closing }.
  • Line 55: observer?.disconnect(); - observer is not defined, please define it before disconnecting.
  • Line 63: setWalletAddress(walletAddress); - walletAddress is not defined, please define it before setting the value.
  • Line 67: const initiateReadOnlyMode = () => { - The function name has a typo, it should be initiateReadOnlyModal.
  • Line 80: const initiateGuestModa = () => { - The function name has a typo, it should be initiateGuestModal.

In the file src/contexts/AppContext.tsx:

  • Line 45: console.log("User Instance in guest mode", userInstance); - A closing parenthesis is missing before console.log.
  • Line 60: console.log("Initialising Push Sdk") - A closing parenthesis is missing after the log message.
  • Line 71: if (!account || !appConfig?.appEnv) return; - It seems that appConfig is not imported. Please import it from the appropriate package.
  • Line 77: if (wallet?.accounts?.length > 0) { - It seems that wallet is not defined. Please define it or remove the condition.

In the file src/index.css:

  • Lines 13-14: Missing closing braces for .select__control selector.
  • Lines 19-20: Missing closing braces for .basic-single selector.

All other parts of the code look good.

@abhishek-01k abhishek-01k merged commit abba9cc into Read-Only-Feature-for-Dapp Dec 15, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants