Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:faq section #1351

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix:faq section #1351

merged 3 commits into from
Jan 4, 2024

Conversation

route-2
Copy link
Contributor

@route-2 route-2 commented Dec 20, 2023

I have added a few extra questions to the docs, in the user section as well as developer section.

@route-2 route-2 requested a review from HarshRajat December 20, 2023 12:59
Copy link

File: src/modules/faq/FaqModule.tsx

  • Line 13: The closing tag for <Span> is missing.
  • Line 15: The opening tag for <ItemVV2> is missing.
  • Line 19: The closing tag for <ItemVV2> is missing.
  • Line 21: The closing tag for <ItemVV2> is missing.
  • Line 32: The opening tag for <ItemVV2> is missing.
  • Line 48: The closing tag for <ItemVV2> is missing.
  • Line 50: The opening tag for <ItemVV2> is missing.
  • Line 55: The opening tag for <ItemVV2> is missing.
  • Line 58: The opening tag for <SpanV2> is missing.
  • Line 60: The closing tag for <ItemVV2> is missing.
  • Line 66: The closing tag for <Span> is missing.
  • Line 71: The opening tag for <Answer> is missing.
  • Line 84: The closing tag for <Answer> is missing.
  • Line 96: There is missing opening tag for <QnAItem>.
  • Line 98: The closing tag for <ItemVV2> is missing.
  • Line 100: The opening tag for <ItemVV2> is missing.
  • Line 108: The opening tag for <Span> is missing.
  • Line 111: The opening tag for <ItemVV2> is missing.
  • Line 120: The closing tag for <Span> is missing.
  • Line 124: The opening tag for <Span> is missing.
  • Line 137: The closing tag for <Span2> is missing.
  • Line 147: The opening tag for <Span2> is missing.
  • Line 152: The opening tag for <AMod> is missing.
  • Line 160: The opening tag for <AMod> is missing.
  • Line 164: The closing tag for <ItemVV2> is missing.
  • Line 179: The closing tag for <ItemVV2> is missing.
  • Line 195: The opening tag for <Span> is missing.
  • Line 200: The closing tag for <Span> is missing.
  • Line 207: The closing tag for <ItemVV2> is missing.
  • Line 219: The opening tag for <Span> is missing.
  • Line 224: The closing tag for <Span> is missing.
  • Line 231: The closing tag for <ItemVV2> is missing.
  • Line 241: The opening tag for <Span> is missing.
  • Line 246: The opening tag for <AMod> is missing.
  • Line 254: The closing tag for <Span> is missing.
  • Line 259: The closing tag for <AMod> is missing.
  • Line 262: The closing tag for <AMod> is missing.
  • Line 266: The closing tag for <AMod> is missing.
  • Line 271: The closing tag for <Span2> is missing.
  • Line 277: The opening tag for <AMod> is missing.
  • Line 284: The closing tag for <AMod> is missing.
  • Line 290: The closing tag for <AMod> is missing.
  • Line 296: The opening tag for <Span2> is missing.
  • Line 308: The closing tag for <Span> is missing.
  • Line 313: The opening tag for <AMod> is missing.
  • Line 321: The closing tag for <AMod> is missing.
  • Line 332: The closing tag for <Span> is missing.
  • Line 336: The opening tag for <Span> is missing.
  • Line 339: The closing tag for <Span> is missing.
  • Line 343: The opening tag for <Span> is missing.
  • Line 346: The closing tag for <Span> is missing.
  • Line 359: The opening tag for <Span> is missing.
  • Line 362: The closing tag for <Span> is missing.
  • Line 371: The closing tag for <Span> is missing.
  • Line 374: The opening tag for <Span> is missing.
  • Line 386: The closing tag for <Span> is missing.
  • Line 390: The closing tag for <ItemVV2> is missing.
  • Line 393: The closing tag for <Container> is missing.
  • Line 416: The closing tag for <Container> is missing.

All looks good.

Copy link
Contributor

@HarshRajat HarshRajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-12-20 at 7 26 42 PM

These are outdated as we have unified SDK now, please redo

src/modules/faq/FaqModule.tsx Outdated Show resolved Hide resolved
src/modules/faq/FaqModule.tsx Outdated Show resolved Hide resolved
src/modules/faq/FaqModule.tsx Show resolved Hide resolved
Copy link

File: src/modules/faq/FaqModule.tsx

  1. In the FaqModule function, there is a missing import statement for ReactGA. Please make sure to import it from the appropriate package.

  2. The toggleShowAnswer function is not defined properly. It is missing opening and closing parentheses after the arrow function declaration. Please update it to const toggleShowAnswer = (id) => { ... }.

  3. Inside the H2 component, the closing Span tag is missing a closing angle bracket ('>'). Please add it after the closing curly brace of the weight prop.

  4. Inside the H2 component, the Questions text is not wrapped in a Span component. Please wrap it with <Span>Questions</Span>.

  5. Inside the SpanV2 component, the background prop is using an undefined theme.default.secondaryBg value. Please make sure this value is defined or remove the prop.

  6. Inside the SpanV2 component, the color prop is using an undefined theme.default.color value. Please make sure this value is defined or remove the prop.

  7. Inside the SpanV2 component, the borderRadius prop is using a template string with an undefined GLOBALS.ADJUSTMENTS.RADIUS.SMALL value. Please make sure this value is defined or remove the template string and replace it with a fixed radius value.

  8. Inside the ItemVV2 component, there is a missing closing tag ('>'). Please add it after the closing parenthesis of the component.

  9. Inside the Question component, the hover prop is using an undefined color value ('#e20880'). Please make sure this color value is defined or remove the prop.

  10. Inside the BsChevronExpand component, the color prop is using an undefined color value ('#ddd'). Please make sure this color value is defined or remove the prop.

  11. Inside the Span component inside the first QnAItem, there is a missing closing tag ('>'). Please add it after the closing curly brace of the color prop.

  12. Inside the Answer component, the Span component is not closed properly. Please add a closing tag ('') before the closing parenthesis of the component.

  13. Inside the QnAItem component, there is a missing closing tag ('>'). Please add it after the closing parenthesis of the component.

  14. Inside the useTheme hook, there is no import statement for useTheme. Please make sure to import it from the appropriate package.

  15. The Container component is using a styled component Section, but the styling props are not defined. Please make sure to define the appropriate style props and their values.

  16. Inside the Container component, there is an undefined globalsMargin variable used in the calc function of the width style attribute. Please make sure this variable is defined or remove this usage.

All looks good.

@route-2 route-2 requested a review from 0xNilesh January 4, 2024 12:35
@route-2 route-2 linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link
Member

@0xNilesh 0xNilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just resolved few typos, rest LGTM

Copy link

github-actions bot commented Jan 4, 2024

  1. In line 8, the initial value for the showAnswers state variable should be an empty array [], not []. So it should be const [showAnswers, setShowAnswers] = React.useState([]);.

  2. In line 12, the toggleShowAnswer function is not correctly updating the showAnswers state variable. It should be updated using the id that is passed as an argument, but the current implementation is incorrect. It should be updated as follows:

const toggleShowAnswer = (id) => {
  setShowAnswers((prevShowAnswers) => {
    const newShowAnswers = [...prevShowAnswers];
    newShowAnswers[id] = !newShowAnswers[id];
    return newShowAnswers;
  });
};
  1. In line 21, there is a typo in the Questions text. It should be wrapped in <Span> tags, similar to other parts of the code. Replace it with <Span weight="600" padding="0px 8px">Questions</Span>.

  2. In line 31, the SpanV2 component is missing a closing tag. Add </SpanV2> to fix the syntax.

  3. In line 149, the closing tag for the container element is missing. Add </Container> to fix the syntax.

  4. In line 169, there is a closing tag ... that should be removed.

  5. In line 177, there is a closing tag ... that should be removed.

  6. In line 282, there is an unnecessary backtick before the comments. Remove it.

  7. In lines 335-412, there are multiple instances where the opening and closing tags for certain elements are missing or misplaced. Review the code and ensure that all tags are properly opened and closed.

  8. In lines 428-435, there are missing closing tags for the Span2, AMod, and A elements. Add closing tags </Span2>, </AMod>, and </A> respectively.

  9. In lines 490-556, there are multiple instances where the closing tags for certain elements are missing. Review the code and ensure that all tags are properly closed.

  10. In lines 558-578, there are missing closing tags for the Spaces and Span2 elements. Add closing tags </Spaces> and </Span2> respectively.

  11. In lines 588-744, there are multiple instances where the closing tags for certain elements are missing. Review the code and ensure that all tags are properly closed.

All other parts of the code appear to be fine.

@0xNilesh 0xNilesh merged commit 9d1bf21 into main Jan 4, 2024
1 check passed
@0xNilesh 0xNilesh deleted the fix-docs branch January 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update FAQ section of dApp
3 participants