Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq and knowledgebase modal for snap #1373

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

abhishek-01k
Copy link
Collaborator

Figma design -> https://www.figma.com/file/PzAmXUMOmwS2ljxufwv44m/PUSH-Prototypes?node-id=21990%3A2433&mode=dev

  • When the user will click on FAQ the FAQ modal will open up with route /snap/route.
  • When the user will click on Knowledge base then the Knowledge modal will open up with /snap/knowledge

Copy link

File: src/App.tsx

  • In the line window?.Olvy?.teardown();, it is unclear what Olvy refers to. It would be helpful to provide some context or explanation for this code.

File: src/assets/PushSnaps/DownArrow.svg

  • The stroke-width attribute should be strokeWidth instead, as it uses camel case in React.

File: src/assets/PushSnaps/UpArrow.svg

  • The stroke-width attribute should be strokeWidth instead, as it uses camel case in React.

File: src/components/MetamaskSnap/SnapFAQModal.tsx

  • The file is empty, it seems that there is no code in this file.

File: src/modules/snap/SnapModule.tsx

  • The code for this file is missing.

File: src/pages/SnapPage.tsx

  • The line import GLOBALS from "config/Globals"; is unused and can be removed.
  • There are conflicting path props in the Route components. Only the last path prop will be used, so the previous ones are redundant and can be removed.

File: src/structure/MasterInterfacePage.tsx

  • The line path={APP_PATHS.Send} element={<SendNotifsPage />} path={APP_PATHS.Receive} element={<ReceiveNotifsPage />} has duplicate path props. Please make sure to provide the correct routing structure and remove any duplicates or conflicts.

@0xNilesh 0xNilesh merged commit dc5a371 into main Jan 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - FAQ and Knowledge base button on Snap Modal
4 participants