Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some snap flow issue #1374

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

abhishek-01k
Copy link
Collaborator

  • Back Button on Settings Modal on /snap route should not take the user to receive notififcation modal.
  • Receive Notification should just redirect user to /snap.
  • Receive notifications should be named appropriately

@abhishek-01k abhishek-01k requested a review from arn4b January 10, 2024 12:02
@abhishek-01k abhishek-01k linked an issue Jan 10, 2024 that may be closed by this pull request
3 tasks
Copy link

File: src/components/PushSnap/InstallPushSnapModal.tsx

  1. Line 11: "primaries/SharedStyling" should be "components/SharedStyling".
  2. Line 21: "useEffect" should be imported from "react" and "useNavigate" should be imported from "react-router-dom".
  3. Line 53: There is a closing parenthesis missing for the "Object.keys(installedSnaps).forEach((snap) => {" statement.
  4. Line 76: "InstallButton" is missing a closing parenthesis before the closing tag "".
  5. Line 97: There is an extra closing parenthesis after the "Verso Wallet" text.
  6. Line 107: "AppstoreInstallBtn" should be "AppStoreInstallBtn".
  7. Line 126: "Get it on" should be wrapped inside a "SpanV2" component.
  8. Line 132: "" should be "".
  9. Line 165: "width: fit-content;" should be removed from the "InstallButton" styled component.
  10. Line 167: "z-Index" should be "z-index" in the "InstallButton" styled component.
  11. Line 180: "const SnapInner = styled.div`" should be closed with a backtick (``) at the end.
  12. Line 182: "const Logo = styled.img" should be closed with a backtick () at the end.
  13. Line 195: "const InstallButton = styled(Button)`" should be closed with a backtick (``) at the end.
  14. Line 200: "const AppstoreInstallBtn = styled(InstallButton)`" should be closed with a backtick (``) at the end.

File: src/components/PushSnap/PushSnapConfigureModal.tsx

  1. Line 7: "useClickAway" should be imported from "react-use".
  2. Line 15: "AiOutlineMore" should be imported from "react-icons/ai".
  3. Line 17: "styled" should be imported from "styled-components".
  4. Line 21: "ReactComponent" should be imported from "assets/PushSnaps/MinusCircle.svg".
  5. Line 25: "useTheme" should be imported from "styled-components".
  6. Line 30: "ReactComponent" should be imported from "assets/info.svg".
  7. Line 31: "Button" should be imported from "components/SharedStyling".
  8. Line 32: "ItemHV2" should be imported from "components/reusables/SharedStylingV2".
  9. Line 34: "Tooltip" should be imported from "components/reusables/tooltip/Tooltip".
  10. Line 35: "shortenText" should be imported from "helpers/UtilityHelper".
  11. Line 36: "useAccount" should be imported from "hooks".
  12. Line 38: "device" should be imported from "config/Globals".
  13. Line 61: Remove the extra closing parenthesis before the semicolon.
  14. Line 63: "console.log('res', res);" should be removed.
  15. Line 107: "getWalletAddresses" should be called inside the "useEffect" hook.
  16. Line 114: "walletSelected" should be initialized with the value "null" instead of undefined.
  17. Line 116: "setWalletSelected(address);" should be called inside the "handleWalletSelect" function.
  18. Line 128: "setWalletSelected(null);" should be called inside the "useClickAway" hook.
  19. Line 132: "return (" should be moved up one line to the same line as "const handleWalletSelect = (address) => {".

HarshRajat
HarshRajat previously approved these changes Jan 11, 2024
arn4b
arn4b previously approved these changes Jan 11, 2024
Copy link
Contributor

@arn4b arn4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abhishek-01k and others added 2 commits January 11, 2024 18:34
@abhishek-01k abhishek-01k dismissed stale reviews from arn4b and HarshRajat via a85d895 January 11, 2024 13:05
@HarshRajat HarshRajat self-requested a review January 11, 2024 15:35
@0xNilesh 0xNilesh merged commit 4eeebf1 into main Jan 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Fix the Snap Flow and Receive Notification
4 participants