Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap Header gets disabled when snaps installed #1378

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

abhishek-01k
Copy link
Collaborator

Snap Info on the header will not be displayed if the Snaps is already installed.

@abhishek-01k abhishek-01k requested a review from arn4b January 12, 2024 10:27
Copy link

  • In AppContext.tsx, line 45, there is a missing closing parenthesis for the function handleConnectWallet.

  • In AppContext.tsx, line 81, there is a missing closing parenthesis after the object literal.

  • In AppContext.tsx, line 44, there is a missing closing parenthesis after the toastType value.

  • In AppContext.tsx, line 97, there is a missing closing parenthesis for the try-catch statement.

  • In AppContext.tsx, line 114, there is a missing closing brace for the useEffect hook.

  • In SnapModule.tsx, line 52, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 74, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 82, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 83, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 84, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 133, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 134, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 153, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 176, there is a missing closing parenthesis after the object literal.

  • In SnapModule.tsx, line 236, there is a missing closing parenthesis after the object literal.

  • In types/context.ts, line 16, there is a missing closing parenthesis for the import statement.

Copy link

In File: src/contexts/AppContext.tsx:

  1. Line 38: There is a missing closing bracket after the line divElement.style.backdropFilter = 'blur(5px)';.

  2. Line 56: There is a missing closing bracket after the line console.log("User Instance", userInstance);.

  3. Line 97: There is a missing closing curly brace at the end of the arrow function initializePushSDK.

  4. Line 99: There is a missing closing bracket after the line console.log("Errror !!!!!", error);.

  5. Line 104: There is a missing closing bracket at the end of the arrow function in the useEffect hook.

  6. Line 105: There is a missing closing bracket after the line initialisePushSdkGuestMode();.

  7. Line 117: There is a missing closing bracket at the end of the functional component AppContextProvider.

In File: src/modules/snap/SnapModule.tsx:

  1. Line 28: There is a missing closing bracket after the line SnapKnowledgeModalComponent.

  2. Line 37: There is a missing closing curly brace at the end of the arrow function handleSettingsClick.

  3. Line 103: There is a missing closing bracket after the line {!snapInstalled ? 'Step 1: Install Snap' : 'Step 1: Completed'}.

  4. Line 109: There is a missing closing bracket after the line Step 2: Sign In with Metamask 🦊.

  5. Line 243: There is a missing closing bracket after the line About this Snap.

  6. Line 117: There is a missing closing bracket at the end of the functional component SnapModule.

In File: src/types/context.ts:

  1. Line 21: There is a missing closing bracket after the line handleConnectWallet: (...) => void;.

All looks good.

Copy link

  • In the AppContext.tsx file:
    • Line 50: There is a missing closing parenthesis after the property getToastIcon function inside the web3onboardToast.showMessageToast() function call.
    • Line 88: There is a missing closing parenthesis after the property account value in the initializePushSDK() function.
    • Line 96-97: There are missing closing parentheses at the end of the initializePushSDK() function.
    • Line 103: There is a missing closing parenthesis at the end of the initialisePushSdkGuestMode() function.
  • In the SnapModule.tsx file:
    • Line 46-47: There is a missing closing curly brace after the SnapKnowledgeModalComponent variable declaration.
    • Line 49-50: There is a missing closing curly brace after the SnapKnowledgeModalComponent variable declaration in the const handleSettingsClick function.
    • Line 81: There is a missing closing parenthesis after the showSnapKnowledgeModal() function call.
    • Line 85-86: There is a missing closing parenthesis after the showSnapFAQModal() function call.
    • Line 99: There is a missing closing bracket after the SnapFAQModal component import.
  • In the types/context.ts file:
    • Line 17: The import statement for PushAPI is missing the closing semicolon.

arn4b
arn4b previously approved these changes Jan 12, 2024
Copy link
Contributor

@arn4b arn4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

  • In AppContextProvider, there is a missing closing parenthesis }) after divElement.style.backdropFilter = 'blur(5px)';.
  • In AppContextProvider, there is a missing closing parenthesis ) after console.log("Errror !!!!!", error);.
  • In AppContextProvider, there is a missing closing parenthesis }) after account: account.
  • In SnapModule, there is a missing closing parenthesis })after ModalComponent: SnapKnowledgeModalComponent,.
  • In AppContextType, there is a missing closing parenthesis }) after toastMessage?: string) => void;.

@HarshRajat HarshRajat requested a review from arn4b January 17, 2024 06:07
Copy link

All looks good.

@0xNilesh 0xNilesh merged commit c5202d1 into main Jan 17, 2024
1 check passed
@0xNilesh 0xNilesh deleted the Snap-Header-fix branch January 17, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide 'Install Snap' alert from header if Snap is already installed
4 participants