Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended chats feature #1428

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

Copy link

In package.json:

  1. "@pushprotocol/restapi": " 0.0.1-alpha.70" - There is an extra space before the version number.
  2. "browserify-zlib": "^0.2.0" - This package is using a caret ^ for versioning, consider using a tilde ~ for more strict versioning.
  3. "blockies-identicon": "0.1.0" - There is a missing comma at the end of the line.

In src/components/Dropdown.tsx:

  1. setShowDropdown?:any; - Consider providing a specific type instead of using any.

In src/components/ProfileModal.tsx:

  1. Inside the dropdownValues mapping, there are missing closing brackets } for some conditional JSX rendering blocks.

In src/primaries/Profile.tsx:

  1. Inside the dropdownValues array, the properties id: 'userSettings', id: 'prodDapp', and link under id: 'prodDapp' are not wrapped in an object with proper key-value pairs.
  2. In the useClickAway hook, corresponding functions for closing dropdowns are missing. Consider adding appropriate handlers.
  3. There is a missing comma after the link property for 'prodDapp'.

The other files are not fully visible, but given the identified issues, please revise the mentioned areas in the code. If there are additional parts of the code or specific functionalities to review, feel free to provide the necessary details.

Copy link

All looks good.

@HarshRajat HarshRajat merged commit e598b8f into updated-phase-3-of-guest-mode Mar 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants