Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed video call chatid issue #1441

Closed
wants to merge 7 commits into from
Closed

fixed video call chatid issue #1441

wants to merge 7 commits into from

Conversation

mishramonalisha76
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Mar 27, 2024 10:48am

Copy link

github-actions bot commented Mar 6, 2024

  • There is a missing closing parenthesis in the getChatId function just before the return statement. It should be added before the return chatId;.

  • The useEffect hook inside the component is missing a closing brace } before the return statement. It should be added after the navigate function call.

  • In the useEffect where the ensName is updated, the dependency array should include the location.pathname to avoid unnecessary re-renders. It should be [ensName, location.pathname].

  • There is a missing closing brace } in the handleCloseSuccessSnackbar function. It should be added after the setOpenSuccessSnackBar function call.

  • In the startVideoCallHandler function, after the conditional statement that checks if reason is 'clickaway', there is a missing closing brace }. It should be added after the return statement.

  • In the InfoMessages array, some comments are not properly commented out. The commented out sections should be enclosed with /* ... */ instead of just //.

  • The conditional check in the JSX for activeTab should use === for comparison instead of ==.

  • The conditional rendering for the LoaderSpinner component should use && instead of && for the condition.

  • The handwave.svg image source is incorrectly imported in the <ImageV2 /> component. It should be corrected.

Overall, the code structure and logic seems fine after these minor corrections.

All looks good.

Copy link
Contributor

@madhur-push madhur-push left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In src/contexts/VideoCallContext.tsx line 70 the private key supplied is coming as undefined, hence, SDK is not able to send notification.
  • In src/components/chat/w2wChat/chatBox/ChatBox.tsx line 156 we need to supply chatId from getChatId() method to send notification.

@mishramonalisha76
Copy link
Collaborator Author

not needed anymore - outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - Fix video functionality
3 participants