Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Profile UI #1445

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Channel Profile UI #1445

merged 5 commits into from
Mar 8, 2024

Conversation

abhishek-01k
Copy link
Collaborator

UI for channel Profile

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Mar 8, 2024 8:27pm

@abhishek-01k abhishek-01k requested a review from HarshRajat March 8, 2024 13:47
Copy link

github-actions bot commented Mar 8, 2024

In the code provided, a few mistakes and typos were found:

  1. In MetaInfoDisplayer.js:

    • The MetaInfoDisplay function misspelled the prop bgColor as bg={bgColor}.
    • The prop padding is missing a value when passed to the MetaContentConatiner.
  2. In ChannelsModule.tsx:

    • The CSS styles in the Container component are missing closing curly braces.
    • The border property value set in the CSS is incorrect, it should indicate the style as well like border: 1px solid ${GLOBALS.ADJUSTMENTS.RADIUS.LARGE};.
  3. In ChannelProfile.tsx:

    • In the NotifsOuter styled component, there's a missing closing curly brace for the media query.
    • Inside the same media query under NotifsOuter, there's a missing semicolon at the end of the width property.
    • In the TextContainer styled component, the align-items property should be align-items: baseline; instead of align-items:baseline;.
    • The background-image property in the ::-webkit-scrollbar-thumb selector is missing a closing parenthesis.
    • The LoaderSpinner component is missing a closing angle bracket.

Given these findings, here are the corrections to be made:

// In MetaInfoDisplayer.js
<MetaContentConatiner bg={bgColor} padding={padding} margin="0 8px" radius="25px" maxWidth="fit-content" onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave}>
// In ChannelsModule.tsx
@media ${device.mobileL} {
    padding: 0px;
    &::-webkit-scrollbar-track {
        background-color: none;
        border-radius: 9px;
  }
  &::-webkit-scrollbar {
      width: 4px;
  }
}
// In ChannelProfile.tsx
&::-webkit-scrollbar-thumb {
        background-image: -webkit-gradient(
          linear,
          left top,
          left bottom,
          color-stop(0.44,  #CF1C84),
          color-stop(0.72, #CF1C84),
          color-stop(0.86, #CF1C84)
        );
}

Please make these corrections based on the findings above. If you need further assistance or clarification, feel free to ask.

All looks good.

Copy link

github-actions bot commented Mar 8, 2024

All looks good.

Copy link

github-actions bot commented Mar 8, 2024

All looks good.

@HarshRajat HarshRajat merged commit 3af9afa into channel-profile Mar 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants