Refactor Inbox and Spam pages #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hrithik73
commented
Mar 11, 2024
hrithik73
commented
- Removed unused code
- Removed commented code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HarshRajat
requested changes
Mar 13, 2024
| @@ -11,32 +11,29 @@ import styled, { ThemeProvider, useTheme } from "styled-components"; | |||
| // Internal Compoonents | |||
| import * as PushAPI from "@pushprotocol/restapi"; | |||
| import { NotificationItem } from "@pushprotocol/uiweb"; | |||
| import { ReactComponent as Close } from 'assets/chat/group-chat/close.svg'; | |||
There was a problem hiding this comment.
- height: 85% causes bottom gap in inbox and spam
- Feedbox should be renamed to Inbox
- spam should be Spam
- ScrollItem should be duplicated and adjusted instead of imported
- height 100% causes loading indicator to hide
- why is dispatch needed provided notifications are loaded internally
HarshRajat
requested changes
Mar 13, 2024
There was a problem hiding this comment.
height: 85% causes bottom gap in inbox and spam
Feedbox should be renamed to Inbox
spam should be Spam
ScrollItem should be duplicated and adjusted instead of imported
height 100% causes loading indicator to hide
why is dispatch needed provided notifications are loaded internally
hrithik73
force-pushed
the
refactor-inbox
branch
from
5c4809d to
1885723
Compare
|
All looks good. |
|
Approved |
0xNilesh
approved these changes
Mar 27, 2024
0xNilesh
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.