-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Migrate SharedStyle to SharedStyle V2 #1466
Conversation
hrithik73
commented
Mar 22, 2024
- Migrate the whole app to use SharedStylingV2
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
All other aspects of the code seem fine with logic and structure. Therefore, the final assessment for the code review is: All looks good. |
576b375
to
ea746dc
Compare
ea746dc
to
3f32dd3
Compare
src/components/AliasSetup.js
Outdated
loading={true} | ||
height={13} | ||
width={4} | ||
/> | ||
<H3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this H3 to H2V2 or SpanV2 according to V2 styling.
src/components/MobileNavButton.js
Outdated
|
||
// Internal Configs | ||
import GLOBALS from 'config/Globals'; | ||
import { nothing } from 'immer'; | ||
import { AppContext } from 'contexts/AppContext'; | ||
import { Span } from './SharedStyling'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Span is used. It should change to SpanV2 from V2 styling.
src/segments/Feedbox.tsx
Outdated
import SearchFilter from 'components/SearchFilter'; | ||
import { convertAddressToAddrCaip } from 'helpers/CaipHelper'; | ||
import CryptoHelper from 'helpers/CryptoHelper'; | ||
import { Item } from 'primaries/SharedStyling'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item is still used. Change this according to V2 styling.
…service/push-dapp into sharedstyle-migration
In AliasProcessing.js:
In AliasSetup.js:
All looks good. |
In the AliasProcessing.js file:
In the AliasSetup.js file:
In the AllNFTs.js file:
In the AllNFTsV2.js file:
Please address the mentioned issues in the code files. |