Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed settings issue #1493

Closed
wants to merge 2 commits into from
Closed

fixed settings issue #1493

wants to merge 2 commits into from

Conversation

mishramonalisha76
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Apr 12, 2024 0:20am

Copy link

In OptinNotifSettingDropdown.tsx file:

  1. There is a missing closing brace after the handleSwitchChange function.
  2. There is a missing closing brace after the handleSwitchChange function inside the handleSwitchChange function.
  3. It seems like there is a missing closing brace after the handleSwitchChange function declaration.
  4. The render method is incomplete. There are missing closing braces.
  5. The useSelector hook needs to return either an object or null value.
  6. There is a missing closing brace after the toggleDropdown function.
  7. The closeDropdown function is missing a closing brace.
  8. The optInHandler function is missing a closing brace.
  9. It seems like there may be an issue with the logic inside the optInHandler function.

In the UpdateNotifSettingDropdown.tsx file:

  1. In the handleSwitchChange function, there is a missing closing brace.
  2. The logic inside the handleSliderChange function seems to be incomplete or missing a closing brace.
  3. Inside the first {setting.type === 3} condition, there is incorrect syntax ({setting.user.lower ?? setting.default.lower}). It should be setting.user.lower || setting.default.lower.
  4. The onChange prop in the RangeSlider component is missing a closing parenthesis.
  5. The console.error(err); statement inside the catch block should be outside the subscribeToast.showMessageToast.

Please review and address these issues. If you need further assistance, feel free to ask.

Copy link

In the file OptinNotifSettingDropdown.tsx:

  1. Typo: You will receive all important updates from this channel. is missing quotes and should be wrapped in quotes. It should be: 'You will receive all important updates from this channel.'.
  2. Missing closing brace } for the handleSwitchChange function.
  3. Missing closing brace } for the OptinNotifSettingDropdownContainer component.
  4. Missing closing brace } for the OptinNotifSettingDropdown component.
  5. Typo: channelSettings: modifiedSettings should be channelSettings.
  6. Typo: Missing closing brace for the useSelector block.
  7. Typo: Missing closing brace for the ChannelSetting type definition.
  8. In the handleSwitchChange function, updatedSettings is used before it is declared.
  9. Typo: SpanV2 is not defined. It should be imported or defined.
  10. Typo: RangeSlider is not defined. It should be imported or defined.

In the file UpdateNotifSettingDropdown.tsx:

  1. Typo: You will receive all important updates from this channel. is missing quotes and should be wrapped in quotes. It should be: 'You will receive all important updates from this channel.'.
  2. Missing closing brace } for the handleSwitchChange function.
  3. Missing closing brace } for the UpdateNotifSettingDropdown component.

All looks good.

@mishramonalisha76
Copy link
Contributor Author

not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Notications setting
1 participant