Rewards V2 #1772
Merged
Rewards V2 #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks good. |
corlard3y
added
the
DO NOT MERGE
|
|
All looks good. |
|
All looks good. |
|
All looks good. |
|
All looks good. |
|
All looks good. |
|
When I load the page for the very first time then it shows me headings only for a second. This is not the correct behaviour. I should be able to see the skeleton states. |
|
The alignment of the activity description, points icons is off in the first item as it only has 1 line of heading while rest of the items have 2 line heading. We need to fix this. 
|
|
If I have already claimed the Discord and Twitter Activity. Then I logout. Then when I click on the verify button of the X or discord. It asks me for connecting my wallet. Then It opens the dicord auth page in new tab or X auth page in new window and also converts the verify button to claimed at the same time. |
Icons are not updated for every activity.
|
|
All looks good. |
|
All looks good. |
|
In the "src/App.tsx" file:
In the "src/blocks/icons/components/BnbMonotone.tsx" file:
In the "src/blocks/icons/components/Clockwise.tsx" file:
Other files seem to be incomplete and need to be reviewed in full. |
|
All looks good. |
|
|
All looks good. |
|
I will start reviewing the code now. Let's begin with the given files. File: src/App.tsx
After fixing the issues: import { FC, useContext, useEffect, useMemo, useState } from 'react';
import ReactGA from 'react-ga';
import { CallBackProps } from 'react-joyride';
import { useDispatch, useSelector } from 'react-redux';
import { useLocation } from 'react-router-dom';
import styled, { ThemeProvider, createGlobalStyle } from 'styled-components';
import { ChatUIProvider, darkChatTheme, IChatTheme } from '@pushprotocol/uiweb';
import InitState from 'components/InitState';
import { AppContext } from 'contexts/AppContext';
import NavigationContextProvider from 'contexts/NavigationContext';
import { useAccount, useInactiveListener } from 'hooks';
import { resetAdminSlice } from 'redux/slices/adminSlice';
import { resetChannelCreationSlice } from 'redux/slices/channelCreationSlice';
import { resetNotificationsSlice } from 'redux/slices/notificationSlice';
import { resetCanSendSlice } from 'redux/slices/sendNotificationSlice';
import { resetSpamSlice } from 'redux/slices/spamSlice';
import { resetUserSlice } from 'redux/slices/userSlice';
import UserJourneySteps from 'segments/userJourneySteps';
import Header from 'structure/Header';
import MasterInterfacePage from 'structure/MasterInterfacePage';
import Navigation from 'structure/Navigation';
import { setIndex, setRun, setWelcomeNotifsEmpty } from './redux/slices/userJourneySlice';
import GLOBALS from 'config/Globals';
import { themeDark, themeLight } from 'config/Themization';
import { appConfig } from 'config/index.js';
import { GlobalContext } from 'contexts/GlobalContext';
import { useUpdateTheme } from '@web3-onboard/react';
import { darkTheme, lightTheme } from 'config/spaceTheme';
import SpaceComponentContextProvider from 'contexts/SpaceComponentsContext';
import SpaceContextProvider from 'contexts/SpaceContext';
import { SpaceWidgetSection } from 'sections/space/SpaceWidgetSection';
import { blocksColors, getBlocksCSSVariables, Notification } from 'blocks';
import APP_PATHS from 'config/AppPaths';
import { useRewardsNotification } from 'common';
...
// Other code here
All looks good.
### File: src/blocks/icons/components/Clockwise.tsx
No issues found.
All looks good.
### File: src/blocks/icons/components/Lock.tsx
No issues found.
All looks good.
### File: src/blocks/icons/components/Stopwatch.tsx
This file is empty. Please fill in the content and then the review can be done.
### File: src/blocks/icons/index.ts
This file seems to be missing content. If there are supposed to be exports in this file, please ensure they are present for review.
### File: src/blocks/illustrations/components/ActivePushPoints.tsx - src/blocks/illustrations/components/StakePushPurpleCoin.tsx
These files are not reviewed as they haven't been provided in full.
Overall, most parts of the code look good with some minor issues that have been pointed out and addressed. Let me know if you need further assistance with the Stopwatch file or any other part of the code. |
rohitmalhotra1420
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
#1744
Description
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now
Additional Context
Review & Approvals
Notes