DApp-1784 fixed the prod dapp option visibility in header

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• 1784

Description

• Problem/Feature:

• Fixed the Production dapp option visibility in prod mode in the header

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

• There is a typo in the imports section. 'Internal Compoonents' should be 'Internal Components'.
• In the import statement for 'Dropdown' component, the path seems incorrect. It should be '../components/Dropdown' instead of '../components/Dropdown'.
• 'getPublicAssetPath' function is being used without being imported or defined in the file. It should be imported from the correct file or defined within the same file.
• There is a commented block of code inside the component that is not being used. It should be either removed or uncommented if needed.
• In the conditional rendering of the Wallet component, the comparison operator in the condition account && account != '' should be corrected to account && account !== ''.
• In the styled component 'Wallet', the property border-radius is being applied twice. It should be removed from the @media (max-width: 992px) block.
• In the styled component 'DropdownItem', the property background is using an undefined value props.theme.header.bg and props.theme.snackbarBorderColor. Ensure that these values are correctly defined in the theme or provide fallback values.
• The inline styles in the 'ToggleArrowImg' styled component do not adhere to the styled-components syntax. You should refactor them to fit the styled-components standards.
• In the 'getPublicAssetPath' calls, double check the paths and make sure they are pointing to the correct locations.

After addressing these issues, please re-run the code review.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-01 13:42 UTC

[corlard3y]

The options still shows up on PROD localhost, when i check

[rohitmalhotra1420]

The options still shows up on PROD localhost, when i check

@corlard3y It is supposed to show everywhere but not on app.push.org.

Clicking on this option opens up app.push.org so that why when user is already on app.push.org there is no point of showing this option.

[corlard3y]

The options still shows up on PROD localhost, when i check

@corlard3y It is supposed to show everywhere but not on app.push.org.

Clicking on this option opens up app.push.org so that why when user is already on app.push.org there is no point of showing this option.

Okay got it, So we are checking with the URL, not the environment. Okay then