Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels listing and details page #1861

Merged
merged 56 commits into from
Oct 18, 2024
Merged

Channels listing and details page #1861

merged 56 commits into from
Oct 18, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented Sep 20, 2024 •
edited
Loading

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

rohitmalhotra1420 and others added 21 commits September 13, 2024 19:13
@rohitmalhotra1420
in progress
4d9e9bd
@mishramonalisha76
added listing api
1fe852e
@rohitmalhotra1420
Ui in progress
e28ef6d
@rohitmalhotra1420
Merge branch 'DAPP-1856-channel-detail' of github.com:push-protocol/p…
cf93727 
…ush-dapp into DApp-1854-channel-listing
@mishramonalisha76
fixed type
43903df
@rohitmalhotra1420
implemented listing
bd1933f
@rohitmalhotra1420
Merge branch 'DAPP-1856-channel-detail' of github.com:push-protocol/p…
049a95d 
…ush-dapp into DApp-1854-channel-listing
@mishramonalisha76
shifted to api call for channel list
9e56995
@rohitmalhotra1420
api fixes
343bee5
@rohitmalhotra1420
Merge branch 'DAPP-1856-channel-detail' of github.com:push-protocol/p…
61143f3 
…ush-dapp into DApp-1854-channel-listing
@rohitmalhotra1420
fixed the ui of card and category
c367239
@rohitmalhotra1420
fixed param type
4887b9f
@mishramonalisha76
added fixed
a859134
@mishramonalisha76
added sdk channel list call
1328eb1
@rohitmalhotra1420
scroll implemented
840b926
@rohitmalhotra1420
Merge branch 'DAPP-1856-channel-detail' of github.com:push-protocol/p…
3158bfa 
…ush-dapp into DApp-1854-channel-listing
@rohitmalhotra1420
fixed the pagination for channel list
02f5370
@rohitmalhotra1420
added listing and search
f609ed9
@mishramonalisha76
added preview
b71bb22
@rohitmalhotra1420
fixed the layout
e7e847d
@mishramonalisha76
channel details page
0e20995
@mishramonalisha76 mishramonalisha76 self-assigned this Sep 20, 2024
@mishramonalisha76 mishramonalisha76 linked an issue Sep 20, 2024 that may be closed by this pull request
Create the new channels detail page #1856
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1861/
on branch gh-pages at 2024-10-18 10:28 UTC

rohitmalhotra1420
rohitmalhotra1420 requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mishramonalisha76 to fix the PR comments.

src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/components/ChannelDetail.tsx Outdated Show resolved Hide resolved
src/modules/channelDetails/ChannelDetails.tsx Show resolved Hide resolved
src/modules/channelDetails/ChannelDetails.tsx Outdated Show resolved Hide resolved
mishramonalisha76
mishramonalisha76 commented Sep 25, 2024
View reviewed changes
src/blocks/textInput/TextInput.tsx Outdated Show resolved Hide resolved
src/common/components/ChannelDetailsCard.tsx Outdated Show resolved Hide resolved
src/common/components/ChannelDetailsCard.tsx Outdated Show resolved Hide resolved
src/queries/hooks/channels/useGetChannelsList.ts Outdated Show resolved Hide resolved
@mishramonalisha76
Copy link
Collaborator Author

The font weight of the channel title in channel listing page doesnot match the one in figma (700 instead of 500 ) @rohitmalhotra1420

abhishek-01k
abhishek-01k previously approved these changes Sep 27, 2024
View reviewed changes
rohitmalhotra1420
rohitmalhotra1420 approved these changes Oct 18, 2024
View reviewed changes
src/common/Common.utils.tsx Outdated Show resolved Hide resolved
src/modules/channels/Channels.utils.ts Outdated Show resolved Hide resolved
src/modules/channels/Channels.utils.ts Outdated Show resolved Hide resolved
src/modules/channels/Channels.tsx Outdated Show resolved Hide resolved
src/modules/channels/Channels.tsx Outdated Show resolved Hide resolved
src/modules/channels/components/AllChannelsList.tsx Outdated Show resolved Hide resolved
src/modules/channels/components/FrontendChannelListItem.tsx Outdated Show resolved Hide resolved
@rohitmalhotra1420 rohitmalhotra1420 merged commit 62db34a into main Oct 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

@abhishek-01k abhishek-01k abhishek-01k left review comments

Assignees

@mishramonalisha76 mishramonalisha76

@abhishek-01k abhishek-01k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the new channels detail page
3 participants
@mishramonalisha76 @rohitmalhotra1420 @abhishek-01k