-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the unlock profile issue #1922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Update the code as per the corrections mentioned above
...
const signer = await provider.getSigner();
await PushAPI.user.create({
account: account,
env: appConfig.appEnv,
signer: signer,
progressHook: onboardingProgressReformatter,
});
const createdUser = await PushAPI.user.get({
// Corrected missing closing curly brace
});
const pvtkey = await PushAPI.chat.decryptPGPKey({
encryptedPGPPrivateKey: createdUser.encryptedPrivateKey,
toUpgrade: true,
}); // Corrected missing closing parenthesis
const createdConnectedUser = { ...createdUser, privateKey: pvtkey };
setConnectedUser(createdConnectedUser);
setPgpPvtKey(pvtkey);
return createdConnectedUser;
} catch (e) {
console.error(e);
// Handle the error appropriately
throw e;
}
};
return (
<AppContext.Provider
value={{
web3NameList,
setWeb3NameList,
MetamaskPushSnapModalComponent,
showMetamaskPushSnap,
setSnapState,
initializePushSDK,
// Other values to be provided
}}
>
{props.children}
</AppContext.Provider>
);
... All looks good. |
|
return !(
userPushSDKInstance?.account === checksumAddr &&
userPushSDKInstance?.env === appConfig.appEnv &&
userPushSDKInstance?.signer === signer &&
!userPushSDKInstance.readmode()
);
dispatch(setUserPushSDKInstance(userInstance));
};
return initializePushSDK(wallet);
const userInstance = await PushAPI.initialize({
decryptedPGPPrivateKey: null,
account: account,
});
});
}); After addressing these issues, the code should be verified, and if everything else is in order, you can write 'All looks good.' |
All mentioned corrections should be reviewed and implemented before merging this code. |
mishramonalisha76
approved these changes
Oct 15, 2024
rohitmalhotra1420
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Fixed the unlock profile issue when in remember me mode
Ticket Number
Description
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now
Additional Context
Review & Approvals
Notes