Fix Unlock Profile(Verify)

[corlard3y]

Pull Request Template

#1927

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

File 1 (useLockedStatus.js):

1. In the useEffect hook, there is a possible issue with the condition if (status === 'error' && isWalletConnected). It might be more appropriate to check if error is truthy instead of just status === 'error'.
2. It would be good to add some error handling for the cases where userDetails?.userId is invalid or not present.
3. In the getLockStatus function, the logic to set isLocked based on certain conditions seems correct.

File 2 (useRewardsAuth.js):

1. The isAuthModalVisible and setIsAuthModalVisible property of the useRewardsContext hook is being used correctly.
2. In the unlockProfile function, it's good to add more error handling and improve the comments for better understanding of the logic.
3. You may need to check the condition in the useEffect hook for status === 'error' && activeTab == 'dashboard' && !isVerifyClicked. It seems to handle flow when there is an error, but further clarification might be needed.

Overall, the code seems to be structured well and contains the necessary logic for managing rewards and authentication flow. Let me know if you need any more specific feedback on certain parts of the code.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-16 11:25 UTC