Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Added padding between header and main container between Light and Dark Mode #1934

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1874

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
    Scroll to the chat section in the dapp, and toggle btw the dark and light mode in any of the envs. The dark mode has a scrollbar, and slightly displaces to the bottom section while light mode does not have a scroll bar.

  • After: What's changed now
    This issue is fixed now, if you toggle between light mode or dark mode. It retains same position across both mode without displacements

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

In the MasterInterfacePage.tsx file, I have found the following issues:

  1. In the Container styled component:

    • The Interface styled component is not closed properly with a backtick (`). Please add a backtick at the end of the Interface styled component styling.
    • The PreviewOuter styled component is not closed properly with a backtick (`). Please add a backtick at the end of the PreviewOuter styled component styling.
    • The PreviewBG styled component is not closed properly with a backtick (`). Please add a backtick at the end of the PreviewBG styled component styling.
    • The PreviewContent styled component is missing the closing backtick (`). Please add a backtick at the end of the PreviewContent styled component styling.
  2. It seems that the styling comments in the styled components are not properly formatted. The comments should be in a proper CSS comment format (/* comment */).

Please correct the styling issues mentioned above to ensure proper syntax in the styled components.

Other than these styling issues, the logic and structure of the code seem to be fine.

All looks good.

Copy link

github-actions bot commented Oct 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-28 10:54 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 899f0d4 into main Oct 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Added padding between header and main container between Light and Dark Mode
2 participants