Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rewards Points Activities #1946

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1944

Description

  • Problem/Feature:
  • Add UD Channel rewards activities
  • Add UD to Dashboard
  • Update Rewards Point Notification Text

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):
  • Update Rewards Activities

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

In the file src/common/hooks/useRewardsNotification.tsx:

  1. There is a missing closing brace } after the onClose function definition.

In the file src/modules/dashboard/configs/dashboardFeaturedChannels.config.ts:

  1. The prodFeaturedChannelsList array is missing the id field in each object.
  2. The arrays alphaFeaturedChannelsList and stagingFeaturedChannelsList have incorrect object structure. The channel key should be inside an object.
  3. The values in the prodFeaturedChannelsList, stagingFeaturedChannelsList, and alphaFeaturedChannelsList arrays should be inside an object with a channel key.
  4. There are missing closing brackets for the arrays prodFeaturedChannelsList, stagingFeaturedChannelsList, and alphaFeaturedChannelsList.

In the file src/modules/rewards/components/RewardsActivityIcon.tsx:

  1. The imports for logos quickSwapLogo, priceTrackerLogo, walletTrackerLogo, shapeShiftLogo, revokeLogo, pwnLogo, udLogo are not correctly structured. They should be imported as image files.
  2. There are missing return statements after the conditions in the RewardsActivityIcon functional component.
  3. The conditions inside the component do not return the components correctly, they should be wrapped in a return statement.
  4. There are missing imports for 'blocks' package components.

In the file src/modules/rewards/utils/activityTypeArray.ts:

  1. There are missing closing brackets for the arrays channelSubscriptionActivities, bonusRewardActivities, dailyRewardActivities, and stakeRewardActivities.

In the file src/queries/types/rewards.ts:

  1. The ActvityType type definition contains a typo. It should be ActivityType.
  2. There is a missing trailing comma after the Reach_100000_subscribers value in the dailyRewardActivities array.
  3. In the Activity type definition, the expiryType property is typed as a number, but it should be one of the values specified in the type definition.

Please address these issues, and let me know if you need further assistance.

Copy link

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-29 10:55 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit d3d99f4 into main Oct 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rewards Points Activities
2 participants