Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Page Content Layout on large devices #1948

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1943

Description

  • Problem/Feature:
  • Fix Page Layout on Large screens
  • On XL screens, adjust header height to 120px

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
    Screenshot 2024-10-29 at 10 23 33

  • After: What's changed now

Screenshot 2024-10-29 at 16 21 16

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

In Globals.js:

  1. There is a missing closing brace '}' for the BIG_MODULES DESKTOP property.
  2. The NAVBAR_SECTIONS object is missing a closing brace '}'.
  3. The ADJUSTMENTS object is missing a closing brace '}'.
  4. The ADJUSTMENTS object should not be inside the CONSTANTS object.
  5. There is a typo in the MARGIN section where 'MARGIN:' should be 'MARGIN'.
  6. There is a reference to 'globalsMargin' which should be corrected to 'GLOBALS'.

In MasterInterfacePage.tsx:

  1. The 'overflow: visible;' style in the Interface styled component is missing a closing brace '}'.
  2. The 'PreviewOuter' styled component is missing a closing brace '}'.
  3. The 'PreviewBG' styled component is missing a closing brace '}'.
  4. The 'PreviewContent' styled component is missing a closing brace '}'.
  5. The 'Preview' styled component is missing a closing brace '}'.

Please make the necessary corrections and ensure the appropriate closing braces are added, and the referenced objects/variables are correctly named.

All looks good.

Copy link

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-30 06:32 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit cfda1ed into main Oct 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Fix Page Content Layout on LG/XL screens
2 participants