Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewards activities list #1955

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1954

Description

  • Problem/Feature:
  • Add Five DeFi Subscribed Channels to the Rewards Points List

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now
    Uploading Screenshot 2024-11-04 at 13.16.31.png…

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 4, 2024

In the file FiveSubscribedDefiChannel.tsx:

  1. There is a missing closing angle bracket ">" for the <rect> tag.
  2. The <path> tag is missing a closing ">".

Other than these issues, the code looks good.

In the file RewardsActivityIcon.tsx:

  1. The <Twitter> component is missing the closing tag </Twitter>.
  2. The components within the if statements are missing return statements.
  3. Some if statements are missing their corresponding return statements. Each if block should return the component or element.

Apart from these issues, the code looks good.

All other files seem to be structured correctly and do not have any apparent issues.

Overall, the code is well-structured, but make sure to address the mentioned issues.

Please resolve the mentioned issues and ensure that the components are correctly returned within the if statements in RewardsActivityIcon.tsx.

Copy link

github-actions bot commented Nov 4, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-05 07:52 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit b559c31 into main Nov 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rewards Points Activities
2 participants