Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1966 Other push monetization payment UI (Purchase a plan) #1974

Conversation

meKushdeepSingh
Copy link
Collaborator

… Spacing Variables

- Completed the integration of the Pricing Page UI.
- Tabs background and spacing variables are still under review; awaiting final decisions from the design team.
- Updated tab background color & button semantics for active tab
- Updated get started button background style
- Added padding at the bottom of the benefit list in the Pricing Plan Box
- Integrated UI for the Purchase Plan feature.
- Integrated UI for the purchase plan modals.
- Adjusted spacing and layout on the pricing page for consistency.
@meKushdeepSingh meKushdeepSingh self-assigned this Nov 18, 2024
@meKushdeepSingh meKushdeepSingh linked an issue Nov 18, 2024 that may be closed by this pull request
- Created a common alert component to display various types of alerts with dynamic content
- Moved FAQ component to common components for reuse across multiple pages
- Updated FAQ answer content and UI
@@ -138,3 +139,49 @@ export const channelCategoriesMap: Record<string, string> = {
'0x63381E4b8fE26cb1f55cc38e8369990594E017b1': 'Service',
'0x80375eAD5561e19668eb1Dd2b6A44Fa14D5eB6BF': 'Service',
};

export const purchasePlanAlertTypes: { [x: string]: (planName?: string) => PurchasePlanAlertObjType } = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const purchasePlanAlertTypes: { [x: string]: (planName?: string) => PurchasePlanAlertObjType } = {
export const purchasePlanAlertConfig: { [x: string]: (planName?: string) => PurchasePlanAlertConfig } = {

@@ -7,3 +9,14 @@ export type ModalResponse = {
export type UnlockProfileModalTypes = 'portal' | 'container';

export type EnvType = 'prod' | 'dev' | 'staging';

export type PurchasePlanAlertObjType = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type PurchasePlanAlertObjType = {
export type PurchasePlanAlertConfig = {

@@ -1,3 +1,5 @@
import { AlertVariant } from 'blocks/alert';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { AlertVariant } from 'blocks/alert';
import { AlertVariant } from 'blocks';

Comment on lines 14 to 15
description: string;
actionText: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: string;
actionText: string;
description: AlertProps["description"];
actionText: AlertProps["actionText"];


export { FAQContainer };

const AnswerOne: FC = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the answer components goes to FAQAnswers.tsx file


const PlanPurchasedModal: FC<PlanPurchasedModalProps> = ({ plan, modalControl, onClose }) => {
const { mode } = useBlocksTheme();
const { isOpen } = modalControl || {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { isOpen } = modalControl || {};
const { isOpen } = modalControl;

Comment on lines 107 to 109
const Logo = styled.img`
height: 40px;
`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

>
<Button
css={css`
flex: 1 0 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required.

modalControl?.open();
}}
css={css`
flex: 1 0 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required. In correct approach.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

- Added illustrations for Push logo with name
- Implemented conditional leading icon in approve button
- Extracted FAQ container and list into separate components
- Created a common file for FAQ answer components
- Refactored code for improved readability and maintainability
Copy link

github-actions bot commented Dec 4, 2024

All looks good.

const { svgProps: props, ...restProps } = allProps;
return (
<IllustrationWrapper
componentName="PushDev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

componentName prop should same as the component name PushLogoWithNameDark

const { svgProps: props, ...restProps } = allProps;
return (
<IllustrationWrapper
componentName="PushDev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link

github-actions bot commented Dec 4, 2024

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit fb2525f into 1965-new-feature-monetization-payment Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👾 [Other] - <Push Monetization Payment UI>
2 participants