-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1966 Other push monetization payment UI (Purchase a plan) #1974
1966 Other push monetization payment UI (Purchase a plan) #1974
Conversation
… Spacing Variables - Completed the integration of the Pricing Page UI. - Tabs background and spacing variables are still under review; awaiting final decisions from the design team.
- Updated tab background color & button semantics for active tab - Updated get started button background style - Added padding at the bottom of the benefit list in the Pricing Plan Box
- Integrated UI for the Purchase Plan feature.
- Integrated UI for the purchase plan modals. - Adjusted spacing and layout on the pricing page for consistency.
- Created a common alert component to display various types of alerts with dynamic content - Moved FAQ component to common components for reuse across multiple pages - Updated FAQ answer content and UI
src/common/Common.constants.ts
Outdated
@@ -138,3 +139,49 @@ export const channelCategoriesMap: Record<string, string> = { | |||
'0x63381E4b8fE26cb1f55cc38e8369990594E017b1': 'Service', | |||
'0x80375eAD5561e19668eb1Dd2b6A44Fa14D5eB6BF': 'Service', | |||
}; | |||
|
|||
export const purchasePlanAlertTypes: { [x: string]: (planName?: string) => PurchasePlanAlertObjType } = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const purchasePlanAlertTypes: { [x: string]: (planName?: string) => PurchasePlanAlertObjType } = { | |
export const purchasePlanAlertConfig: { [x: string]: (planName?: string) => PurchasePlanAlertConfig } = { |
@@ -7,3 +9,14 @@ export type ModalResponse = { | |||
export type UnlockProfileModalTypes = 'portal' | 'container'; | |||
|
|||
export type EnvType = 'prod' | 'dev' | 'staging'; | |||
|
|||
export type PurchasePlanAlertObjType = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export type PurchasePlanAlertObjType = { | |
export type PurchasePlanAlertConfig = { |
src/common/Common.types.ts
Outdated
@@ -1,3 +1,5 @@ | |||
import { AlertVariant } from 'blocks/alert'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { AlertVariant } from 'blocks/alert'; | |
import { AlertVariant } from 'blocks'; |
src/common/Common.types.ts
Outdated
description: string; | ||
actionText: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: string; | |
actionText: string; | |
description: AlertProps["description"]; | |
actionText: AlertProps["actionText"]; |
|
||
export { FAQContainer }; | ||
|
||
const AnswerOne: FC = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the answer components goes to FAQAnswers.tsx file
|
||
const PlanPurchasedModal: FC<PlanPurchasedModalProps> = ({ plan, modalControl, onClose }) => { | ||
const { mode } = useBlocksTheme(); | ||
const { isOpen } = modalControl || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { isOpen } = modalControl || {}; | |
const { isOpen } = modalControl; |
const Logo = styled.img` | ||
height: 40px; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
> | ||
<Button | ||
css={css` | ||
flex: 1 0 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required.
modalControl?.open(); | ||
}} | ||
css={css` | ||
flex: 1 0 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required. In correct approach.
src/modules/pricing/Pricing.utils.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this
- Added illustrations for Push logo with name - Implemented conditional leading icon in approve button - Extracted FAQ container and list into separate components - Created a common file for FAQ answer components - Refactored code for improved readability and maintainability
All looks good. |
const { svgProps: props, ...restProps } = allProps; | ||
return ( | ||
<IllustrationWrapper | ||
componentName="PushDev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
componentName prop should same as the component name PushLogoWithNameDark
const { svgProps: props, ...restProps } = allProps; | ||
return ( | ||
<IllustrationWrapper | ||
componentName="PushDev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
… illustration and removed unused imports
All looks good. |
fb2525f
into
1965-new-feature-monetization-payment
Ticket Number