Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the flow for Snaps in user settings page #1975

Merged

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

Ticket Number

Description

Snap Flow in User settings is made similar to the /snap route.

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • After: What's changed now
Screenshot 2024-11-22 at 12 19 38 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@abhishek-01k abhishek-01k self-assigned this Nov 22, 2024
Copy link

All looks good.

Copy link

github-actions bot commented Nov 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-22 10:59 UTC

Copy link

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit 2776d9c into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants