Fix stake section

[corlard3y]

Pull Request Template

#1977

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• Users unable to stake in new epoch, for already claimed tasks

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In ActivityButton.tsx:

1. 'ActvityType' is a typo, it should be 'ActivityType'.
2. The import statement for 'ActivityVerificationButton' is present but the component is not used in the code. Please verify if it is required or remove the import if not needed.
3. There is a console.log statement inside the component. It is recommended to remove this debugging statement in the final code.
4. In the last conditional block, there are ellipsis (...). Please ensure that the actual logic is present in the code and not omitted.
5. The condition 'usersSingleActivity?.data?.currentEpoch == uniV2StakeData?.currentEpoch' has a missing comparison value on the right side.

In StakePushActivitiesListItem.tsx:

1. 'setErrorMessage' prop is defined and passed down to children components but not used in the component logic. Please verify if it is required.
2. In the conditional rendering based on 'isLockedOrNotConnected', the closing curly brace '}' is missing after the else block.
3. The component 'RewardsActivityIcon' is being rendered conditionally inside the 'Box' component. Please verify the conditional logic.
4. The provided code is incomplete, ensure that all components are used correctly and the logic is complete.

In StakePushSection.tsx:

1. 'Box' component is used with an incorrect property 'flexDirection={{ ml: 'column', initial: 'row' }}'. It should be 'flexDirection={{ 'ml': 'column', 'initial': 'row' }}'.
2. There is a missing closing curly brace '}' for the destructuring of 'useGetUserRewardsDetails' props.
3. The code has broken HTML structure in the comment section 'Staking rewards can be claimed once per reset after a cooldown period of 7 days.'. It should be wrapped in a comment tag.
4. The component 'StakePushActivitiesListItem' is being rendered with a missing line for passing down the props to it.

Overall, the code should be further evaluated to ensure completeness and correctness in the logic implementation.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-25 11:40 UTC