Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1971 other user settings on UI #1986

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

github-actions bot commented Dec 6, 2024

In the UpgradePlanModal component:

  1. The planFeatures array is missing curly braces {} around the objects.
  2. The closing tag for cancelButtonProps is missing in the Modal component.

In the UserPlanAndBillings component:

  1. In the Box component, there is an extra opening angle bracket '<' before the second Box component.
  2. The closing tag for the Text component is missing after the Upgrade Plan text.
  3. The variant 'bm-regular' in the Text component should be 'bs-regular'.
  4. In the ProgressBar component, the progress value is hard-coded to 250, it should be dynamic based on the item's subtitle.
  5. The closing angle bracket '>' is missing in multiple places.
  6. The variant 'c-bold' in the Text component should be 'h4-semibold'.
  7. The CSS prop should have the correct property name which is 'cursor', instead of 'coursor'.
  8. The closing tag for the Button component is missing after the Upgrade Plan button.

In the Themization.js file:

  1. The object ends with a comma after the last key-value pair which can cause potential issues.
  2. The missing export keyword before the export statement.

All looks good.

@corlard3y corlard3y merged commit 992687d into 1965-new-feature-monetization-payment Dec 6, 2024
1 of 2 checks passed
@corlard3y corlard3y deleted the 1971-other-user-settings-on-ui branch December 6, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant