Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rewards Toast Notif not closing #1996

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1993

Description

  • Problem/Feature:
  • Rewards Toast Notifs not closing

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Dec 24, 2024 that may be closed by this pull request
Copy link

  • There is a typo in the import statement: 'sonner' should be corrected to 'sommelier'.
  • The usage of the notification.hide() function inside the handleNotificationClose function in NotificationItem component should be notification.hide() instead of notification.hide().
  • There is a missing closing bracket after the <NotificationContainer> component in the NotificationItem component. It should be added at the end of the <NotificationContainer> component.
  • The StyledToaster component is extending Toaster but Toaster component is not defined in the provided code snippet. It needs to be imported or defined for this code to work properly.

After addressing the above issues, the code looks good.

Copy link

github-actions bot commented Dec 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-12-24 12:42 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 4fee3ee into main Dec 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - <Rewards Toast Notification Close Button Not working>
2 participants