Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - Push Token Fee not increased on updating channel settings #1214

Closed
Aman035 opened this issue Apr 8, 2024 · 0 comments · Fixed by #1212
Closed

🐛 [BUG] - Push Token Fee not increased on updating channel settings #1214

Aman035 opened this issue Apr 8, 2024 · 0 comments · Fixed by #1212
Assignees
@Aman035
Labels
bug Something isn't working

Comments

@Aman035
Copy link
Member

Aman035 commented Apr 8, 2024

Expected Behaviour

Push Toekn fee increases linearly ast every modification of channel settings. Pus SdK should take care of this case

Current Behaviour

Currently only 50 tokens are approved leading in trx failure from smart contracts

Reproduction steps

1. Try calling channel.settings fn

Screenshots

![DESCRIPTION](LINK.png)

Relevant Logs

No response

Dapp Env

Prod (app.push.org), Staging (staging.push.org), Dev (dev.push.org)

Browsers

No response
@Aman035 Aman035 added the bug Something isn't working label Apr 8, 2024
@Aman035 Aman035 self-assigned this Apr 8, 2024
@Aman035 Aman035 linked a pull request Apr 8, 2024 that will close this issue
fix: test cases and minor bugs #1212
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: test cases and minor bugs push-protocol/push-sdk
1 participant
@Aman035