Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test cases and minor bugs #1212

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: test cases and minor bugs #1212

merged 1 commit into from
Apr 8, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Apr 8, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented Apr 8, 2024

In the file packages/restapi/src/lib/channels/getChannel.ts:

  1. Line 44: Missing closing bracket '}' after the catch block should be added.
  2. Line 48: 'return decryptedPrivateKey;' is missing a closing bracket '}' at the end of the function.
  3. Line 89: 'export async function getDecryptedPrivateKey(' is missing a closing bracket '}' at the end of the function.
  4. Line 98: 'export const {verificationProof};' should be 'return { verificationProof };' to correctly return an object.
  5. Line 99: The 'decryptWithWalletRPCMethod' function call is missing a closing ')'.
  6. Line 110: 'createUserProps.account = wallet.account;' is missing a closing bracket '}' at the end of the condition.
  7. Line 112: 'createUserProps.account = user.did;' is missing a closing bracket '}' at the end of the condition.
  8. Line 117: 'ValidationError: gpgPrivateKey is required as input' typo in the error message, should be 'pgpPrivateKey is required as input'.

After addressing the above issues, the code looks good.

All looks good.

@Aman035 Aman035 changed the title fix: tes cases and minor bugs fix: test cases and minor bugs Apr 8, 2024
@Aman035 Aman035 requested a review from mohammeds1992 April 8, 2024 07:51
@Aman035 Aman035 linked an issue Apr 8, 2024 that may be closed by this pull request
@Aman035 Aman035 merged commit d30e095 into main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants