Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow groupImage and groupDesc to be updated to null #1118

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Feb 20, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the file packages/restapi/src/lib/pushapi/chat.ts:

  1. In the latest method, there is a missing closing curly brace } after defining threadHash and intent variables.
  2. In the history method, there is a missing closing curly brace } after setting the value of reference.
  3. In the update method, there is a missing closing curly brace } after the group not found error is thrown.
  4. In the update method, the updateGroupProfile and updateGroupConfig functions should be prefixed with await as they are asynchronous functions.

In the file packages/restapi/src/lib/pushapi/pushAPITypes.ts:

  1. In the GroupCreationOptions interface, the rules property is missing a closing curly brace }.
  2. In the RemoveFromGroupOptions interface, the role property should be of type 'ADMIN' | 'MEMBER' but it's missing in the code snippet provided.
  3. In the GetGroupParticipantsOptions interface, the role property should be of type 'ADMIN' | 'MEMBER' but it's defined as string.
  4. In the VideoInitializeOptions interface, the media property is defined outside the config object.

In the file packages/restapi/tests/lib/chat/chat.group.test.ts:

  1. In the test case for updating a group, there are missing closing curly braces } for the it blocks after setting updatedGroup as private and updating group description and image as null.

In the file packages/restapi/tests/lib/chat/chat.test.ts:

  1. In the test case for sending a message in readOnly mode, the let errorCaught variable is not properly initialized and should be moved inside the try block.
  2. In the test case for decrypting a message, the userBob.chat.decrypt function should be awaited as it returns a promise.

Overall, the code requires some corrections and missing parts to be added for correct execution.

Let me know if you need further assistance with fixing these issues.

@Aman035 Aman035 merged commit 0b7fac0 into main Feb 21, 2024
1 check passed
mohammeds1992 pushed a commit that referenced this pull request Feb 26, 2024
* fix: optimize chat.list (#1115)

* fix: allow groupImage and groupDesc to be updated to null (#1118)

* fix: mark ethers as optional peer dependency

* fix: change typeDataDomain

* fix: update readme
@Aman035 Aman035 deleted the fix-upgradeGroupProfile branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Cannot set groupImage to null with updateGroupProfile function
2 participants