Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweaked parameters #1137

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Mar 1, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@akp111 akp111 requested review from mohammeds1992 and Siddesh7 March 1, 2024 14:50
Copy link

github-actions bot commented Mar 1, 2024

In the file packages/restapi/src/lib/constantsV2.ts:

  1. There is a missing comma after the initVideoCallData property in the VIDEO object:
INITIAL_DATA: initVideoCallData,
  1. There is a typo in the commented section, "Change this do" should be "Change this to":
// TODO: Change this to . type
  1. There is a missing comma after the ALPHA_FEATURES property in the VIDEO object:
USER: { ENCRYPTION_TYPE: ENCRYPTION_TYPE },
  1. There is a missing comma after the BROADCAST property in the TYPE object within NOTIFICATION:
TARGETTED: 3,
  1. There are missing import statements in the file packages/restapi/src/lib/pushNotification/channel.ts for ChannelSearchOptions, NotificationOptions, CreateChannelOptions, NotificationSettings, ChannelFeedsOptions, ChannelOptions, and ChannelInfoOptions.

  2. The notifications method in the Channel class is missing a closing brace before the comment block and has a missing closing brace and parenthesis at the end:

return await PUSH_CHANNEL.getChannelNotifications({
  channel: account as string,
  filter,
  raw,
  limit,
});
  1. There are missing closing braces in the error handling block of the notifications method.

  2. There are missing closing braces and parentheses at the end of the createSettingsRes return statement in the info method.

In the file packages/restapi/tests/lib/notification/channel.test.ts:

  1. In the describe block, there is a typo in "noChannelAddress" variable definition, it should be "noChannelAddress: string;":
let noChannelAddress: string;
  1. In the first it block under "notifications," there is a missing closing brace and parenthesis at the end of the notifications method call:
const res = await userAlice.channel.notifications("eip155:0xD8634C39BBFd4033c0d3289C4515275102423681",{raw: true});
  1. In the second it block under "notifications," there is a missing closing brace and parenthesis at the end of the notifications method call:
const res = await userAlice.channel.notifications("0xD8634C39BBFd4033c0d3289C4515275102423681",{raw: false, filter: CONSTANTS.NOTIFICATION.TYPE.TARGETTED});

After addressing these issues, the code should be checked again thoroughly.

Copy link

github-actions bot commented Mar 1, 2024

  • In the file constantsV2.ts, there is a missing comma after the initVideoCallData value.
  • In the same file, there is a missing comma after the USER object closing brace.
  • In the same file, there is a missing import statement for ChannelInfoOptions, ChannelSearchOptions, NotificationOptions, CreateChannelOptions, NotificationSettings, and ChannelFeedsOptions.
  • In the same file, there are some comments that are not properly formatted with *.

Once these issues are fixed, the code looks good.

All looks good.

@mohammeds1992 mohammeds1992 merged commit cd277e6 into main Mar 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants