Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoupgrade): turn autoUpgrade True in low level SDK fns #1138

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix(autoupgrade): turn autoUpgrade True in low level SDK fns #1138

merged 2 commits into from
Mar 5, 2024

Conversation

ankur12-1610
Copy link
Contributor

Fixes Issue

#1091

Changes proposed

Turn autoUpgrade True in low level SDK fns

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

options?.autoUpgrade !== undefined
? options?.autoUpgrade
: defaultOptions.autoUpgrade,
autoUpgrade: true,
Copy link
Member

@Aman035 Aman035 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not require any change.

decryptPGPKey default toUpgrade param need to be turned true

@Aman035
Copy link
Member

Aman035 commented Mar 5, 2024

@Aman035 should this be also changed?

https://github.com/ethereum-push-notification-service/push-sdk/blob/ee074a1890aecabb308b15e8eebf890f058af232/packages/restapi/src/lib/user/upgradeUser.ts#L70

No, this is fine
Upgrade is not directly used and should have toUpgrade flag as false to work properly

@Aman035 Aman035 merged commit 5717b1d into push-protocol:main Mar 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Turn autoUpgrade True in low level SDK fns
2 participants