Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add decryptedPGPPrivateKey in options #1216

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@mohammeds1992 mohammeds1992 linked an issue Apr 8, 2024 that may be closed by this pull request
@mohammeds1992 mohammeds1992 requested a review from Aman035 April 8, 2024 12:38
Copy link

github-actions bot commented Apr 8, 2024

In the PushAPI.ts file, I have found a few issues:

  1. In the constructor of PushAPI class, there are some missing commas when passing arguments to Profile and Encryption constructors. It should be corrected as follows:

       this.profile = new Profile(
         this.account,
         this.cache
       );
    
       this.encryption = new Encryption(
         this.pgpPublicKey
       );
  2. There is a missing comma in the initialization of Video class. It should be corrected as follows:

       this.video = new Video(
         this.signer
       );
  3. There is a missing semicolon after the assignment of errors array. It should be corrected as follows:

       this.errors = initializationErrors || [];
  4. In the method static async initialize, the if (!signer && !options?.account) statement is missing an opening curly brace {.

  5. In the if condition below decryptedPGPPrivateKey = options?.decryptedPGPPrivateKey;, there is a missing closing curly brace }.

  6. There are some logics present that seem to be incomplete or need further implementation such as the case where decryptedPGPPrivateKey is not present and the catch block where an error occurs while decrypting PGP private key.

  7. In the PushAPIInitializeProps interface of pushAPITypes.ts, the SpaceListType enum is missing a closing curly brace }.

  8. In the ManageSpaceOptions interface, the RemoveFromSpaceOptions interface, and the RemoveFromGroupOptions interface, the interfaces are empty. They should have at least one property for clarity.

Please address these issues accordingly.

Otherwise, the code looks good overall.

@mohammeds1992 mohammeds1992 merged commit ed9d3a7 into main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push API initialize with decryptedPGPKey
2 participants