Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accept request #707

Merged
merged 7 commits into from
Sep 14, 2023
Merged

feat: add accept request #707

merged 7 commits into from
Sep 14, 2023

Conversation

arn4b
Copy link
Contributor

@arn4b arn4b commented Sep 13, 2023

No description provided.

@arn4b arn4b changed the base branch from main to feat/space-v2 September 13, 2023 07:51
@github-actions
Copy link

File: packages/restapi/src/lib/spaceV2/SpaceV2.ts

  • Line 19: The closing parenthesis is missing. It should be }).

  • Line 31: The closing parenthesis is missing. It should be }).

  • Line 48: There is a typo in the comment. It should be will instead of * will.

  • Line 54: There is a typo in the comment. It should be will instead of * will.

  • Line 61: There is a missing closing parenthesis. It should be }).

  • Lines 63-72: The functions removePeer, getPeerConnection, setPeerConnection, and getConnectedPeerIds are missing closing curly brackets.

  • Line 75: There is an unnecessary async keyword before connect.

  • Line 78: There is an unnecessary async keyword before disconnect.

  • Line 81: There is an unnecessary async keyword before request.

  • Line 84: There is an unnecessary async keyword before invite.

  • Line 86: There is a missing closing curly bracket.

File: packages/restapi/src/lib/spaceV2/acceptInvite.ts

  • Line 9: There is an unused import for produce from immer.

  • Line 48: There is a comment that is not properly formatted. It should start with // instead of /*.

  • Line 99: There is a missing closing parenthesis. It should be )}.

  • Lines 101-105: There is an unnecessary indentation.

  • Line 114: There is an unnecessary closing parenthesis.

File: packages/restapi/src/lib/spaceV2/helpers/getIceServerConfig.ts

  • Line 12: There is a missing semicolon at the end of the import statement.

File: packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts

  • Lines 38-40: There is unnecessary indentation.

  • Line 78: There is a missing closing parenthesis. It should be const { data: encryptedData } = await axios.get(apiEndpoint); }).

@github-actions
Copy link

File: packages/restapi/src/lib/spaceV2/SpaceV2.ts

  1. In line 16, there is a missing closing parenthesis for the object inside incomingPeerStreams property.
  2. In line 22, there is a missing closing square bracket for the pendingPeerStreams property.

File: packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts

  1. In line 20, there is an extra opening curly brace for the UserInfoType interface definition.

All looks good in the remaining code files.

@github-actions
Copy link

In SpaceV2.ts:

  1. Line 40: There is a closing parenthesis missing after the "retryCount" field declaration in the "incomingPeerStreams" array.

  2. Line 43: There is an opening parenthesis missing for the "pendingPeerStreams" array.

  3. Line 67: The function signature for the setter function should be:

    setSpaceV2Data: (fn: (data: SpaceV2Data) => void) => void;

    The return type should be void instead of SpaceV2Data.

  4. Line 100: There is a closing parenthesis missing after the "retryCount" field declaration in the "incoming" array.

In acceptInvite.ts:

No issues found.

In sendSpaceNotification.ts:

  1. Line 90: The interface declaration for UserInfoType is missing a closing curly brace.

  2. Line 97: The parameter name should be senderAddressInCaip instead of channel.

In index.ts:

  1. Line 19: The import statement for "IMediaStream" is missing.

  2. Line 47: There is a closing parenthesis missing after the "incoming" array declaration.

  3. Line 59: There is a closing parenthesis missing after the "stream" field declaration in the "local" object.

  4. Line 62: There is a closing parenthesis missing after the "incomingPeerStreams" field declaration in the "spaceInfo" object.

  5. Line 63: There is an opening parenthesis missing for the "pendingPeerStreams" field declaration.

  6. Line 106: There is a closing parenthesis missing after the "signalData" field declaration in the "VideoAcceptRequestInputOptions" interface.

  7. Line 111: The "type" field in the "details" object should have the value of "SPACE_ACCEPT_REQUEST_TYPE" instead of SPACE_REQUEST_TYPE.

  8. Line 108: The value of the "type" field in the "VideoAcceptRequestInputOptions" interface should be SPACE_ACCEPT_REQUEST_TYPE instead of SPACE_REQUEST_TYPE.

  9. Line 117: The "type" field in the "details" object should have the value of "SPACE_ACCEPT_REQUEST_TYPE" instead of SPACE_REQUEST_TYPE.

All looks good.

@github-actions
Copy link

File: packages/restapi/src/lib/spaceV2/SpaceV2.ts

  • Line 52: The closing square bracket is missing for the incomingPeerStreams array element.
  • Line 54: The closing square bracket is missing for the pendingPeerStreams array element.
  • Line 210: The closing parenthesis is missing after peerId parameter in the removePeer method.
  • Line 221: The closing parenthesis is missing after peerId parameter in the getPeerConnection method.
  • Line 227: The closing parenthesis is missing after peerConnection parameter in the setPeerConnection method.
  • Line 232: The closing parenthesis is missing after getConnectedPeerIds method.
  • Line 289: There is a typo in the comment, "disconnections" is misspelled as "diconnections".
  • Line 297: There is a typo in the comment, "made by host to listener" should be "made by the host to the listener".

File: packages/restapi/src/lib/spaceV2/acceptInvite.ts

  • This file seems to be empty.

File: packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts

  • Line 67: The opening curly brace should be placed after the => arrow, not before it.
  • Line 68: UserInfoType interface is not closed properly, it requires a closing curly brace.
  • Line 70: SpaceDataType interface is not closed properly, it requires a closing curly brace.
  • Line 122: There is a typo in the console.log statement, "sendSpacelNotification" should be "sendSpaceNotification".
  • Line 125: getCAIPWithChainId function call has an incomplete second parameter, it should be recipientAddress.
  • Line 129: getCAIPWithChainId function call has an incomplete parameter, it should include chainId and senderAddress.
  • Line 144: senderType value 1 should be replaced with a constant value from payloads/constants.
  • Line 157: The cta value should not be an empty string. Provide a meaningful call-to-action text.
  • Line 207-215: There are unnecessary line breaks and ellipsis (...) within the sendNotification function call.

Other than that, the code looks fine.

packages/restapi/src/lib/spaceV2/acceptInvite.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/acceptInvite.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/acceptInvite.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/acceptInvite.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

All looks good.

@0xNilesh 0xNilesh merged commit 54b215d into feat/space-v2 Sep 14, 2023
1 check passed
@0xNilesh 0xNilesh deleted the arnab/accept-req branch September 14, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants