Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group encryption #719

Closed
wants to merge 5 commits into from
Closed

feat: group encryption #719

wants to merge 5 commits into from

Conversation

strykerin
Copy link
Contributor

No description provided.

@strykerin strykerin requested a review from Aman035 September 19, 2023 18:42
@github-actions
Copy link

File: packages/examples/sdk-backend-node/chat/chat.ts

  1. Line 10: Typo in the variable name 'pgpDecrpyptedPvtKey'. It should be 'pgpDecryptedPvtKey'.
  2. Line 23: Missing closing parentheses ')' after 'env as ENV'.
  3. Line 26: Missing closing curly brace '}' after 'console.log(response)'.
  4. Line 33: Missing closing parentheses ')' after 'groupName: groupName'.
  5. Line 36: Missing closing curly brace '}' after 'console.log(response)'.
  6. Line 42: Missing closing parentheses ')' after 'chatId: chatId'.
  7. Line 45: Missing closing curly brace '}' after 'console.log(response)'.
  8. Line 49: Missing closing parentheses ')' after 'siGroupName: groupName'.
  9. Line 52: Missing closing curly brace '}' after 'console.log(response)'.

File: packages/restapi/src/lib/chat/approveRequest.ts

  1. Line 58: Typo in the function name 'approve'. It should be 'approveRequest'.
  2. Line 75: Typo in the comment. It should be 'Request state. As of now, only Approved is allowed'.
  3. Line 97: Missing closing curly brace '}' after 'pgpPrivateKey = null'.

File: packages/restapi/src/lib/chat/getGroup.ts

  1. Line 8: Typo in the function name 'GetGroupType'. It should be 'GetGroupOptionsType'.
  2. Line 20: Typo in the function name 'getGroup'. It should be 'getGroupByName'.
  3. Line 39: Missing closing parentheses ')' after 'response.data'.
  4. Line 43: Missing closing curly brace '}' after 'console.error(...)'.

File: packages/restapi/src/lib/chat/helpers/getEncryptedSecret.ts

  1. Line 13: Missing closing parentheses ')' after 'getAPIBaseUrls(env)'.
  2. Line 15: Missing closing parentheses ')' after 'response.data.encryptedSecret'.
  3. Line 19: Missing closing curly brace '}' after 'console.error(...)'.

@github-actions
Copy link

File: packages/restapi/src/lib/chat/approveRequest.ts

  • The import statement for AES should be adjusted to: import * as AES from '../chat/helpers/aes';
  • There is a typo in the comment before the status property, it should be corrected to: // Request state. As of now, only 'Approved' is allowed
  • The commented out sigType property should be removed.

File: packages/restapi/src/lib/chat/approveRequest.ts

  • The import statement for PGPHelper should be adjusted to: import { PGPHelper, IPGPHelper } from '../chat/helpers/pgp';
  • There is a missing closing parentheses ")" for the second parameter of approveCore function.

File: packages/restapi/src/lib/chat/approveRequest.ts

  • The import statement for CryptoJS should be adjusted to: import * as CryptoJS from 'crypto-js';

File: packages/restapi/src/lib/chat/approveRequest.ts

  • There is a missing closing curly brace "}" after the else block that handles the isGroup variable assignment.

File: packages/restapi/src/lib/chat/approveRequest.ts

  • There is a missing closing curly brace "}" after the else block that handles the assignment of fromDID and toDID variables.

File: packages/restapi/src/lib/chat/approveRequest.ts

  • The axios.put function call should be adjusted to use await keyword.

File: packages/restapi/src/lib/chat/getGroup.ts

  • The import statement for getAPIBaseUrls should be adjusted to: import { getAPIBaseUrls } from '../helpers';

File: packages/restapi/src/lib/chat/getGroup.ts

  • There is a missing closing curly brace "}" after the catch block.

File: packages/restapi/src/lib/chat/helpers/getEncryptedSecret.ts

  • The import statement for getAPIBaseUrls should be adjusted to: import { getAPIBaseUrls, ENV } from '../../helpers';

File: packages/restapi/src/lib/chat/helpers/getEncryptedSecret.ts

  • There is a missing closing parentheses ")" in the catch block.

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • There is a missing closing curly brace "}" after the for loop.

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • The export statement for decryptConversation should have a return type of Promise<any>.

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • There is a missing closing curly brace "}" after the foreach loop.

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • The export statement for addDeprecatedInfo should have a return type of (chats: IFeeds[]) => IFeeds[].

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • There is a missing closing curly brace "}" after the return statement.

File: packages/restapi/src/lib/chat/helpers/inbox.ts

  • The export statement for addDeprecatedInfoToMessages should be removed.

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for AES should be adjusted to: import * as AES from '../chat/helpers/aes';

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for getAPIBaseUrls should be adjusted to: import { getAPIBaseUrls } from '../helpers';

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for PGPHelper should be adjusted to: import { PGPHelper, IPGPHelper } from '../chat/helpers/pgp';

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for getConnectedUserV2Core should be adjusted to: import { getConnectedUserV2Core } from '../helpers';

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for getAccountAddress should be adjusted to: import { getAccountAddress, getUserDID } from '../helpers';

File: packages/restapi/src/lib/chat/updateGroup.ts

  • The import statement for getGroup should be adjusted to: `

@Aman035
Copy link
Member

Aman035 commented Nov 27, 2023

Done by #810

@Aman035 Aman035 closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants