Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): fix recurring video calls bug, rpc in example app #850

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

madhur-push
Copy link
Contributor

No description provided.

Copy link

File: packages/examples/sdk-frontend/README.md

  • There are no mistakes or typos. All looks good.

File: packages/examples/sdk-frontend/package.json

  • The closing curly brace of the "dependencies" object is missing.
  • The closing curly brace of the "package.json" file is missing.

File: packages/examples/sdk-frontend/pages/_app.tsx

  • The import statement for "React" is missing.
  • The commented out code block for "SpacesUIProvider" is not closed properly.
  • There is an extra closing curly brace after the "wagmiClient" object declaration.
  • There is an extra closing parenthesis after "{...pageProps}".
  • There are a few extra empty lines at the end of the file.

File: packages/examples/sdk-frontend/pages/video.tsx

  • There is a typo in the comment. "meesage" should be "message".
  • The closing parenthesis for the "parseData?.details?.type" condition is missing.
  • There is an extra closing curly brace at the end of the file.

File: packages/restapi/src/lib/video/Video.ts

  • There are no mistakes or typos. All looks good.

@mohammeds1992 mohammeds1992 merged commit 7012721 into main Nov 16, 2023
1 check passed
@madhur-push madhur-push deleted the 849-fix-example-app-rpc-and-bug-fix-in-video branch January 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Push video example app RPC not working & bug in recurring call
2 participants