Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description #894

Merged
merged 473 commits into from
Nov 28, 2023
Merged

Fix description #894

merged 473 commits into from
Nov 28, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Nov 28, 2023

No description provided.

arn4b and others added 26 commits October 3, 2023 17:52
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer (#736)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

---------

Co-authored-by: Nilesh Gupta <[email protected]>
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  1. Line 12: There is a missing '+' operator at the end of the line. It should be added before the 'ticker' variable.
    Replace:
    ticker;

    With:
    ticker + '+';

  2. Line 20: There is a missing '+' operator at the end of the line. It should be added before the 'ticker' variable.
    Replace:
    ticker;

    With:
    ticker + '+';

  3. Line 27: There is a missing '+' operator at the end of the line. It should be added before the 'upper' variable.
    Replace:
    ele.data.upper;

    With:
    ele.data.upper + '+';

  4. Line 32: There is a missing '+' operator at the end of the line. It should be added before the 'upper' variable.
    Replace:
    ele.default.upper;

    With:
    ele.default.upper + '+';

  5. Line 54: There is a missing '}' character at the end of the line.
    Replace:
    ele.default.upper +

    With:
    ele.default.upper + '}';

  6. Line 62: There is a missing '}' character at the end of the line.
    Replace:
    userSetting = userSetting + BOOLEAN_TYPE + SETTING_DELIMITER + enabled;

    With:
    userSetting = userSetting + BOOLEAN_TYPE + SETTING_DELIMITER + enabled + '}';

  7. Line 64: There is a missing ')' character at the end of the line.
    Replace:
    userSetting = userSetting + SETTING_SEPARATOR;

    With:
    userSetting = userSetting + SETTING_SEPARATOR + ')';

  8. Line 77: There is a missing '}' character before the return statement.
    Replace:
    return numberOfSettings + SETTING_SEPARATOR + userSetting;

    With:
    return numberOfSettings + SETTING_SEPARATOR + userSetting + '}';

  9. Line 82: There is a missing '}' character before the return statement.
    Replace:
    if (!setting) {
    return null;

    With:
    if (!setting) {
    return null; }

  10. Line 87: There is a missing '}' character before the return statement.
    Replace:
    if (i != setting.length - 1)
    userSetting = userSetting + SETTING_SEPARATOR;

    With:
    if (i != setting.length - 1)
    userSetting = userSetting + SETTING_SEPARATOR + '}';

  11. Line 97: There is a missing '}' character before the return statement.
    Replace:
    return {
    setting: notificationSetting.replace(/^+/, ''),
    description: notificationSettingDescription.replace(/^+/, ''),
    };

    With:
    return {
    setting: notificationSetting.replace(/^+/, ''),
    description: notificationSettingDescription.replace(/^+/, ''),
    }; }

  12. Line 118: There is a missing '}' character at the end of the line.
    Replace:
    this.account!);

    With:
    this.account!); }

@mohammeds1992 mohammeds1992 self-requested a review November 28, 2023 08:18
@mohammeds1992 mohammeds1992 merged commit 9e2a41e into main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants