Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get subscribe response #895

Merged
merged 473 commits into from
Nov 28, 2023
Merged

Get subscribe response #895

merged 473 commits into from
Nov 28, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Nov 28, 2023

No description provided.

arn4b and others added 26 commits October 3, 2023 17:52
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer (#736)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

---------

Co-authored-by: Nilesh Gupta <[email protected]>
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

File: packages/restapi/src/lib/channels/getSubscribers.ts

  1. In line 13, there is a typo in the import statement. It should be "Subscribers" instead of "Subscribers".

  2. In line 17, there is a typo in the comment. It should be "GET /v1/channels/:channelId/subscribers" instead of "GET /v1/channels/:channelId/:subscribers".

  3. In line 22, there is a typo in the type name. It should be "GetChannelSubscribersOptionsType" instead of "GetChannelSubscribersOptions".

  4. In line 32, there is a missing closing parenthesis after the condition "if (page <= 0)".

  5. In line 35, there is a missing closing parenthesis after the condition "if (limit > 30)".

  6. In line 39, there is a missing closing bracket after the "if(category)" block.

  7. In line 47, there is a missing closing parenthesis after the condition "if (category)".

  8. In line 48, there is a missing closing parenthesis after the condition "if (options && options.page)".

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  1. In line 12, there is a missing closing bracket after the "UserSetting[]" array.

File: packages/restapi/src/lib/pushNotification/channel.ts

  1. In line 67, there is a missing closing parenthesis after the condition "if (!validateCAIP(channel!))".

  2. In line 69, there is a missing closing bracket after the "PUSH_CHANNEL._getSubscribers({" block.

  3. In line 81, there is a missing closing parenthesis after the condition "if (info && info.channel_settings)".

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  1. In line 43, there is a missing closing parenthesis after the condition "if (!setting)".

  2. In line 54, there is a missing closing brace after the "if (typeof ele.value == 'number')" block.

  3. In line 59, there is a missing closing bracket after the "else" block.

  4. In line 63, the closing parenthesis of the for loop is missing.

  5. In line 82, there is a missing closing bracket after the "if (channelInfo)" block.

  6. In line 103, there is a missing closing bracket after the "if (aliasInfoFromChannel)" block.

File: packages/restapi/tests/lib/pushNotification/base.test.ts

  1. In line 222, there is a missing closing parenthesis after the condition "it('Test minimal conversion', async () => {".

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

No issues found.

File: packages/restapi/tests/lib/pushNotification/notification.test.ts

No issues found.

All looks good.

@mohammeds1992 mohammeds1992 self-requested a review November 28, 2023 10:42
@mohammeds1992 mohammeds1992 merged commit 0145aed into main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants