948 passvideo chatprofile #957

KlausMikhaelson · 2023-12-21T12:41:59Z

Fixes Issue #948

Changes proposed

added an option in chat profile to pass a component so that features like video or other customizations can be implemented easily

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

…quirement

github-actions · 2023-12-21T12:42:27Z

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatProfile.tsx

Please remove the commented lines for chatId.

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

In line 11, import { ChatView } from '@pushprotocol/uiweb'; should be removed as it is not being used in the code.

File: packages/uiweb/src/lib/components/chat/ChatProfile/AddWalletContent.tsx

In line 20, there is a typo, key={index} should be inside parentheses.

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

In line 224, there is a typo, const is missing before getImage().

File: packages/uiweb/src/lib/components/chat/ChatViewComponent/ChatViewComponent.tsx

In line 80, there is a typo, Conatiner should be Container.

File: packages/uiweb/src/lib/components/chat/CreateGroup/AddWallets.tsx

This file is empty. Please remove it.

File: packages/uiweb/src/lib/components/chat/exportedTypes.ts

This file is empty. Please remove it.

mishramonalisha76 · 2023-12-22T06:52:38Z

packages/uiweb/src/lib/components/chat/ChatProfile/AddWalletContent.tsx

            onSubmit()
          }}
          isLoading={isLoading}
          memberListCount={memberList?.length > 0}
          theme={theme}
+          disabled={isLoading || groupMembers.length === 0}


why is this needed?

for making the create group button disable when the group is being created and to add a condition that there should be at least one more wallet address added here

mishramonalisha76 · 2023-12-22T06:52:55Z

packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

@@ -20,7 +20,7 @@ const ChatViewComponentTest = () => {
        <ChatView 
        onVerificationFail={() => console.log("BOIIII RETURNNNSSSSS")} 
        chatId='0xf8250D363BD1F25f52F10C21188fe82c68C049c4' 
-
+        Component={() => <div><a href="https://github.com" target="_blank">Test</a></div>}


any reason the Component parameter in captalized

it was actually giving an error that Property 'component' does not exist on type 'JSX.IntrinsicElements' while using small letters and I think since it's a component it will be better to keep it capitalized but let me know what you think about it

@KlausMikhaelson let make the Component to some meaningful name and in small case, also give the type as HTMLDivElement.

mishramonalisha76 · 2023-12-22T06:56:42Z

packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

@@ -127,6 +128,11 @@ export const ChatProfile: React.FC<IChatProfile> = ({
          margin="0 20px 0 auto"
          alignSelf="center"
        >
+          {(Component && !groupInfo) && (
+            <Section>


add dimensions for the section

github-actions · 2023-12-22T08:32:32Z

In ChatProfile.tsx:

Line 10: There is a comment inside the props of ChatProfile component. You should remove it.
Line 22: There is a comment inside the props of ChatProfile component. You should remove it.
Line 32: There is a comment inside the props of ChatProfile component. You should remove it.

In ChatViewComponent.tsx:

Line 15: variable name is "ChatViewComponentTest" but it should be "ChatViewComponent".
Line 102: There is an extra space after "=" in "groupInfoModalPositionType = MODAL_POSITION_TYPE.GLOBAL". It should be "groupInfoModalPositionType = MODAL_POSITION_TYPE.GLOBAL".

In AddWalletContent.tsx:

Line 73: There is a closing parenthesis ")" missing after "darkIcon={}".

In ChatProfile.tsx:

Line 114: The closing parenthesis ")" for "-> toDataURL()?.toString();" is missing.

In ChatViewComponent.tsx:

Line 146: There is a missing closing parenthesis ")" after "padding="13px"".

In AddWallets.tsx:

File is empty.

In exportedTypes.ts:

File is empty.

All looks good.

github-actions · 2023-12-24T15:02:39Z

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatProfile.tsx

In the ChatProfileTest component, there is an unused import statement for ChatProfile from "@pushprotocol/uiweb". You can remove it since it is not being used.

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

In the ChatViewComponentTest component, there are unused import statements for CreateGroupModal, MODAL_BACKGROUND_TYPE, and MODAL_POSITION_TYPE from "@pushprotocol/uiweb". You can remove them since they are not being used.

File: packages/uiweb/src/lib/components/chat/ChatProfile/AddWalletContent.tsx

In the MultipleMemberList styled component, there is a missing closing angle bracket ">" after the key={index} prop. You should add the closing angle bracket.

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

In the ChatProfile component, there is a typo in the import statement for the GroupInfoModal component. The correct import statement should be import { GroupInfoModal } from './GroupInfoModal';.
In the ChatProfile component, there is a typo in the import statement for the isValidETHAddress helper function. The correct import statement should be import { isValidETHAddress } from '../helpers/helper';.
In the getProfileImage function, there is an unnecessary conditional block that always returns the value createBlockie?.(chatId)?.toDataURL()?.toString();. You can remove this conditional block since it does not have any effect on the return value.
In the getProfileName function, there is a missing opening parenthesis "(" before the isMobile conditional statement. You should add the opening parenthesis.
In the getProfileName function, there is a missing closing parenthesis ")" after the true) parameter of the shortenText function. You should add the closing parenthesis.
In the getProfileName function, there is an unnecessary conditional block that always returns the value shortenText(chatInfo.did?.split(':')[1] ?? '', 6, true) when ensName is falsy. You can remove this conditional block and directly return the value.
In the getProfileName function, there is an unnecessary conditional block that always returns the value shortenText(chatId, 6, true) when chatInfo is falsy. You can remove this conditional block and directly return the value.

File: packages/uiweb/src/lib/components/chat/ChatViewComponent/ChatViewComponent.tsx

In the ChatViewComponent component, the options parameter should be destructured as {} instead of IChatViewComponentProps.
In the ChatViewComponent component, there is an unused import statement for useEffect from 'react'. You can remove it since it is not being used.
In the ChatViewComponent component, there is a missing import statement for Conatiner from '../reusables'. You should add the import statement.
In the ChatViewComponent component, the padding prop in the Conatiner component should be changed to padding instead of padding="13px".
In the ChatViewComponent component, the theme prop should be passed to the ChatProfile component as theme={theme}.

File: packages/uiweb/src/lib/components/chat/CreateGroup/AddWallets.tsx

The file is empty. You can remove it.

File: packages/uiweb/src/lib/components/chat/exportedTypes.ts

The file is empty. You can remove it.

All looks good.

KlausMikhaelson added 2 commits December 19, 2023 07:41

fix: fixed create group btn not disabling and added minimum member re…

ea1a3a8

…quirement

feat: implemented option to pass a component in chatprofile

4eea456

KlausMikhaelson requested a review from mishramonalisha76 December 21, 2023 12:42

KlausMikhaelson requested a review from mohammeds1992 December 21, 2023 12:42

mishramonalisha76 requested changes Dec 22, 2023

View reviewed changes

fix: added styling for the component in chat profile

d2985ae

fix: changed component type and how it is rendered

de355a9

mohammeds1992 approved these changes Dec 26, 2023

View reviewed changes

mishramonalisha76 approved these changes Dec 26, 2023

View reviewed changes

KlausMikhaelson merged commit 2ce025a into main Dec 26, 2023
1 check passed

KlausMikhaelson deleted the 948-passvideo-chatprofile branch December 26, 2023 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

948 passvideo chatprofile #957

948 passvideo chatprofile #957

KlausMikhaelson commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023

mishramonalisha76 Dec 22, 2023

KlausMikhaelson Dec 22, 2023

mishramonalisha76 Dec 22, 2023

KlausMikhaelson Dec 22, 2023

mishramonalisha76 Dec 24, 2023

mishramonalisha76 Dec 22, 2023

github-actions bot commented Dec 22, 2023

github-actions bot commented Dec 24, 2023

948 passvideo chatprofile #957

948 passvideo chatprofile #957

Conversation

KlausMikhaelson commented Dec 21, 2023 • edited Loading

Fixes Issue #948

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

github-actions bot commented Dec 21, 2023

mishramonalisha76 Dec 22, 2023

Choose a reason for hiding this comment

KlausMikhaelson Dec 22, 2023

Choose a reason for hiding this comment

mishramonalisha76 Dec 22, 2023

Choose a reason for hiding this comment

KlausMikhaelson Dec 22, 2023

Choose a reason for hiding this comment

mishramonalisha76 Dec 24, 2023

Choose a reason for hiding this comment

mishramonalisha76 Dec 22, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 22, 2023

github-actions bot commented Dec 24, 2023

KlausMikhaelson commented Dec 21, 2023 •

edited

Loading