Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Feature Enhancement] - <Recheck and re-assign onlyAdmin() vs onlyGovernance modifiers> #281

Closed
zaryab2000 opened this issue Jan 31, 2024 · 1 comment
Closed

😈 [Feature Enhancement] - <Recheck and re-assign onlyAdmin() vs onlyGovernance modifiers> #281

zaryab2000 opened this issue Jan 31, 2024 · 1 comment
Assignees
@zaryab2000
Labels
enhancement New feature or request priority-1 Indicates highest priority
Milestone
Push Governance v...

Comments

@zaryab2000
Copy link
Collaborator

Feature name

No response

Describe the Enhancement

Recheck the functions that has onlyAdmin() and onlyGovernance() modifier and align onlyGovernance() modifier only to the functions that are supposed to controlled via governance. Rest can be assigned onlyAdmin()

POC if available

No response

Contract Name

Core Contract
@zaryab2000 zaryab2000 added enhancement New feature or request priority-1 Indicates highest priority labels Jan 31, 2024
@zaryab2000 zaryab2000 self-assigned this Jan 31, 2024
@zaryab2000 zaryab2000 added this to the Push Governance v1.0.0 milestone Jan 31, 2024
@zaryab2000 zaryab2000 mentioned this issue Feb 1, 2024
Merged
@zaryab2000
Copy link
Collaborator Author

this is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaryab2000 zaryab2000

Labels
enhancement New feature or request priority-1 Indicates highest priority
Projects
None yet
Milestone
Push Governance v1.0.0
Development

No branches or pull requests
1 participant
@zaryab2000