Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

281 only admin vs only gov new #284

Merged
merged 2 commits into from
Feb 2, 2024
Merged

281 only admin vs only gov new #284

merged 2 commits into from
Feb 2, 2024

Conversation

zaryab2000
Copy link
Collaborator

@zaryab2000 zaryab2000 commented Feb 1, 2024 •
edited
Loading

This PR mainly re-assigns the modifiers in the core contract:

  • pause/unPause -> moved to onlyAdmin
  • blockchannel() -> Moved to onlyGovernance

Fixes #281

@zaryab2000 zaryab2000 added enhancement New feature or request priority-2 Medium priority labels Feb 1, 2024
@zaryab2000 zaryab2000 added this to the Push Governance v1.0.0 milestone Feb 1, 2024
@zaryab2000 zaryab2000 requested a review from Zartaj0 February 1, 2024 12:36
@zaryab2000 zaryab2000 self-assigned this Feb 1, 2024
@zaryab2000 zaryab2000 merged commit 2852656 into pushContracts-v2.5.0-dev Feb 2, 2024
@zaryab2000 zaryab2000 deleted the 281-onlyAdmin_vs_onlyGov_new branch February 2, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zartaj0 Zartaj0 Zartaj0 approved these changes

Assignees

@zaryab2000 zaryab2000

Labels
enhancement New feature or request priority-2 Medium priority
Projects
None yet
Milestone
Push Governance v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zaryab2000 @Zartaj0