Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Feature Enhancement] - <Modification of Auto-Subscription logic in Channel Creation procedure is required> #282

Closed
zaryab2000 opened this issue Jan 31, 2024 · 1 comment
Closed

😈 [Feature Enhancement] - <Modification of Auto-Subscription logic in Channel Creation procedure is required> #282

zaryab2000 opened this issue Jan 31, 2024 · 1 comment
Assignees
@zaryab2000
Milestone
Push Core V2.5 (a...

Comments

@zaryab2000
Copy link
Collaborator

Feature name

As of now, during any channel creation, the channel creator is supposed to subscribe to pushChannelAdmin (which is supposed to be the Push Protocol Channel on the dapp)

Describe the Enhancement

With the change in the admin address, this logic needs modification.

POC if available

No response

Contract Name

Core Contract
@zaryab2000 zaryab2000 self-assigned this Feb 14, 2024
@zaryab2000 zaryab2000 mentioned this issue Feb 14, 2024
Merged
@zaryab2000
Copy link
Collaborator Author

this is now closed as Auto-subscription is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaryab2000 zaryab2000

Labels
None yet
Projects
None yet
Milestone
Push Core V2.5 (and Clean-Ups)
Development

No branches or pull requests
1 participant
@zaryab2000