214 2nd new unwanted function removal #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaryab2000
added
enhancement
Zartaj0
reviewed
Feb 15, 2024
| @@ -94,7 +94,6 @@ contract PushCoreV2_5 is Initializable, PushCoreStorageV1_5, PausableUpgradeable | |||
| if ( | |||
| !( | |||
| (channels[_channel].channelState == 1 && msg.sender == _channel) | |||
| || (msg.sender == pushChannelAdmin && _channel == address(0x0)) | |||
There was a problem hiding this comment.
This line is not removed for the temp contract.
There was a problem hiding this comment.
this is now resolved @Zartaj0 . Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly includes 3 important changes:
List of changes if EPNS Alerter support is removed
1. Modifiers
1. onlyChannelOwner
2. Functions
1. _createChannel → Line 289 :: Remove auto-supscription completely ✅
2. destroyTimeBoundChannel → Line 322 :: Remove auto-unsubscription completely ✅
3. getChannelVerfication → Line 437 :: remove address (0x0) ✅
This PR resolves #214 and #282