Remove Ruby <2.3 base64 decoding workaround #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older Ruby versions, WebPush.decode64 was introduced to wrap Base64.urlsafe_decode64 to prevent errors decoding "unpadded" urlsafe-encoded input. Since Ruby 2.3, Base64.urlsafe_decode64 can now gracefully decode padded and unpadded input. Given WebPush now supports Ruby 3+, we should be able to remove this workaround gracefully. I've added basic specs to demonstrate and perhaps catch any potential (though unlikely) future regressions in Ruby. For historical discussion of the issue: https://bugs.ruby-lang.org/issues/10740
|
@rossta Thanks for the pull requests! I have merged them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older Ruby versions,
WebPush.decode64was introduced to wrapBase64.urlsafe_decode64to prevent errors decoding "unpadded" urlsafe-encoded input.Since Ruby 2.3,
Base64.urlsafe_decode64can now gracefully decode padded and unpadded input. GivenWebPushnow supports Ruby 3+, we should be able to remove this workaround gracefully.I've added basic specs to demonstrate and perhaps catch any potential (though unlikely) future regressions in Ruby.
For historical discussion of the issue:
https://bugs.ruby-lang.org/issues/10740