Fix JS position in sprig.triggerRefreshOnLoad

putyourlightson · Aug 29, 2024 · 513f544 · 513f544
1 parent 9595d92
commit 513f544
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Release Notes for Sprig Core
 
-## 2.12.0 - Unreleased
+## 2.12.0 - 2024-08-29
 
 ### Added
 
@@ -10,6 +10,10 @@
 
 - Updated htmx to version 2.0.2 ([changelog](https://github.com/bigskysoftware/htmx/blob/master/CHANGELOG.md#202---2024-08-12)).
 
+### Fixed
+
+- Fixed the positioning of the JavaScript output by the `sprig.triggerRefreshOnLoad` function.
+
 ### Deprecated
 
 - Deprecated `sprig.getIsBoosted`, `sprig.getIsError`, `sprig.getIsHistoryRestoreRequest`, `sprig.getIsInclude`, `sprig.getIsRequest`, `sprig.getIsSuccess`. Use `sprig.isBoosted`, `sprig.isError`, `sprig.isHistoryRestoreRequest`, `sprig.isInclude`, `sprig.isRequest`, `sprig.isSuccess` instead.

diff --git a/src/base/Component.php b/src/base/Component.php
@@ -319,7 +319,7 @@ public static function triggerRefreshOnLoad(string $selector = ''): void
             });
         JS;
 
-        Craft::$app->getView()->registerJs($js);
+        Craft::$app->getView()->registerJs($js, View::POS_END);
     }
 
     /**

diff --git a/src/services/ComponentsService.php b/src/services/ComponentsService.php
@@ -393,7 +393,7 @@ private function getParseableTags(string $content): array
             Craft::error('Backtrack limit was exhausted!', __METHOD__);
         }
 
-        return $matches[0] ?? [];
+        return [];
     }
 
     /**